Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-squash redirected the parsed output #101

Closed
praiskup opened this issue Nov 29, 2018 · 1 comment
Closed

docker-squash redirected the parsed output #101

praiskup opened this issue Nov 29, 2018 · 1 comment
Assignees
@praiskup

Comments

@praiskup
Copy link
Contributor

goldmann/docker-squash#145 and goldmann/docker-squash#144 -> we should fix our scripting so it works for both versions, or use the library.
@praiskup praiskup self-assigned this Nov 29, 2018
@praiskup
Copy link
Contributor Author

Per report from @omron93

praiskup added a commit to praiskup/container-common-scripts that referenced this issue Nov 30, 2018
@praiskup
build: use docker_squash lib, not docker-squash script
4096419 
The docker-squash script used to print the squashed <image id> on
stderr, but recently it was changed so the image id is printed to
stdout.  To be able to parse image id from both docker_squash
versions (before and after this change), we'd have to have some
ugly if-fork to detect the docker_squash version.

So rather let's do as upstream suggested in [1] and use the
docker_squash library directly.

Also add a simple CI test for the ./squash.py file.

[1] goldmann/docker-squash#145

Fixes: sclorg#101
@praiskup praiskup mentioned this issue Nov 30, 2018
Merged
praiskup added a commit to praiskup/container-common-scripts that referenced this issue Nov 30, 2018
@praiskup
build: use docker_squash lib, not docker-squash script
d2daeb4 
The docker-squash script used to print the squashed <image id> on
stderr, but recently it was changed so the image id is printed to
stdout.  To be able to parse image id from both docker_squash
versions (before and after this change), we'd have to have some
ugly if-fork to detect the docker_squash version.

So rather let's do as upstream suggested in [1] and use the
docker_squash library directly.

Also add a simple CI test for the ./squash.py file.

[1] goldmann/docker-squash#145

Fixes: sclorg#101
praiskup added a commit to praiskup/container-common-scripts that referenced this issue Nov 30, 2018
@praiskup
build: use docker_squash lib, not docker-squash script
e982c54 
The docker-squash script used to print the squashed <image id> on
stderr, but recently it was changed so the image id is printed to
stdout.  To be able to parse image id from both docker_squash
versions (before and after this change), we'd have to have some
ugly if-fork to detect the docker_squash version.

So rather let's do as upstream suggested in [1] and use the
docker_squash library directly.

Also add a simple CI test for the ./squash.py file.

[1] goldmann/docker-squash#145

Fixes: sclorg#101
praiskup added a commit to praiskup/container-common-scripts that referenced this issue Dec 4, 2018
@praiskup
build: use docker_squash lib, not docker-squash script
91e108d 
The docker-squash script used to print the squashed <image id> on
stderr, but recently it was changed so the image id is printed to
stdout.  To be able to parse image id from both docker_squash
versions (before and after this change), we'd have to have some
ugly if-fork to detect the docker_squash version.

So rather let's do as upstream suggested in [1] and use the
docker_squash library directly.

Also add a simple CI test for the ./squash.py file.

[1] goldmann/docker-squash#145

Fixes: sclorg#101
praiskup added a commit to praiskup/container-common-scripts that referenced this issue Dec 4, 2018
@praiskup
build: use docker_squash lib, not docker-squash script
b6b0fef 
The docker-squash script used to print the squashed <image id> on
stderr, but recently it was changed so the image id is printed to
stdout.  To be able to parse image id from both docker_squash
versions (before and after this change), we'd have to have some
ugly if-fork to detect the docker_squash version.

So rather let's do as upstream suggested in [1] and use the
docker_squash library directly.

Also add a simple CI test for the ./squash.py file.

[1] goldmann/docker-squash#145

Fixes: sclorg#101
praiskup added a commit to praiskup/container-common-scripts that referenced this issue Dec 5, 2018
@praiskup
build: use docker_squash lib, not docker-squash script
a4672a4 
The docker-squash script used to print the squashed <image id> on
stderr, but recently it was changed so the image id is printed to
stdout.  To be able to parse image id from both docker_squash
versions (before and after this change), we'd have to have some
ugly if-fork to detect the docker_squash version (or play with FD
redirection).

So rather let's do as upstream suggested in [1] and use the
docker_squash library directly.

Also add a simple CI test for the ./squash.py file.

[1] goldmann/docker-squash#145

Fixes: sclorg#101
praiskup added a commit that referenced this issue Dec 5, 2018
@praiskup
build: use docker_squash lib, not docker-squash script
e175c02 
The docker-squash script used to print the squashed <image id> on
stderr, but recently it was changed so the image id is printed to
stdout.  To be able to parse image id from both docker_squash
versions (before and after this change), we'd have to have some
ugly if-fork to detect the docker_squash version (or play with FD
redirection).

So rather let's do as upstream suggested in [1] and use the
docker_squash library directly.

Also add a simple CI test for the ./squash.py file.

[1] goldmann/docker-squash#145

Fixes: #101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@praiskup praiskup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@praiskup