Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed POM files to generate correct OSGi Export-Package instructions #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paulbakker
Copy link

The instructions to generate OSGi Export-Package headers are not correct yet. The bundles don't resolve in an OSGi framework. This pull request fixes that.

@thjaeckle
Copy link

+1

Without the provided fix only classes directly located in com.gs.collections.api and com.gs.collections.impl package can be used in other OSGi Bundles.
The "reactor-bus" (using gs-collections) bundle requires for example:

com.gs.collections.api.block.procedure,
com.gs.collections.api.list,
com.gs.collections.impl.list.mutable,
com.gs.collections.impl.map.mutable

@motlin
Copy link
Collaborator

motlin commented Jan 5, 2016

Unfortunately, we still can't take pull requests in this repository. We've recently opened up Eclipse Collections where we'll be able to accept contributions. Eclipse Collections 7.0.0 is nearly identical to GS Collections 7.0.0 but with "com.gs.collections" changed to "org.eclipse.collections". It's also released under the EDL and EPL.

If you need this fix in GS Collections to use with existing projects that depend on it, I could backport the fix.

@bigkahuna1uk
Copy link

Is there a reason for the fork from GS to Eclipse collections? Is this due to differing licenses? Are the two codebases likely to diverge?

@motlin
Copy link
Collaborator

motlin commented Jan 5, 2016

We'll work on new features in Eclipse Collections. We'll probably just port
critical fixes to GS Collections.

On Tue, Jan 5, 2016 at 6:42 PM bigkahuna1uk notifications@github.com
wrote:

Is there a reason for the fork from GS to Eclipse collections? Is this due
to differing licenses? Are the two codebases likely to diverge?


Reply to this email directly or view it on GitHub
#17 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants