golem-component-compilation-service - fix #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigoo
approved these changes
May 10, 2024
senia-psm
reviewed
May 10, 2024
| @@ -91,6 +91,8 @@ async fn run(config: ServerConfig, prometheus: Registry) -> Result<(), Box<dyn s | |||
|
|
|||
| info!("Server started on port {}", config.grpc_port); | |||
|
|
|||
| drop(http_server); // explicitly keeping it alive until the end | |||
There was a problem hiding this comment.
I really like using explicit drop, just want to inform you that in other places in code we are using _ prefix instead of explicit drop (let _http_server = ...). Rust keeps all names variables alive till the end of code block.
senia-psm
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.