Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approval races - fix agreements locks #1014

Merged
merged 2 commits into from
Feb 5, 2021

Conversation

nieznanysprawiciel
Copy link
Contributor

@nieznanysprawiciel nieznanysprawiciel commented Feb 4, 2021

resolves: golemfactory/yagna-triage#40

I ran 100 requestor in sequence to test it.
I'm not sure if it is reliable test enough, so I added annotation on Graphana, that will warn us if this error happens again.

@nieznanysprawiciel nieznanysprawiciel self-assigned this Feb 4, 2021
@nieznanysprawiciel nieznanysprawiciel marked this pull request as ready for review February 4, 2021 16:25
@nieznanysprawiciel nieznanysprawiciel requested a review from a team February 4, 2021 16:25
@nieznanysprawiciel nieznanysprawiciel changed the title Approval reces - fix agreements locks Approval races - fix agreements locks Feb 4, 2021
Copy link
Contributor

@tworec tworec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tworec tworec merged commit 3fc42e2 into release/v0.6 Feb 5, 2021
@tworec tworec deleted the market/fix-agreement-locks branch February 5, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants