Market - reject agreement #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nieznanysprawiciel
force-pushed
the
market/reject-agreement
branch
from
b0a9cee
to
ff9c49f
Compare
jiivan
reviewed
Feb 18, 2021
Co-authored-by: Dariusz Rybi <jiivan@users.noreply.github.com>
jiivan
previously approved these changes
Feb 18, 2021
jiivan
force-pushed
the
market/reject-agreement
branch
from
2c5a666
to
55d17b5
Compare
jiivan
approved these changes
Feb 25, 2021
kmazurek
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #381
I added code to
wait_for_approvalthat checks rejection reason in database and tries to return it.But spec requires to return only strings as
RejectedorCancelled. I think we should adjust spec at some point, since knowing rejection reason seems very useful.