New payment verification mechanism #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiezzel
force-pushed
the
wiezzel/payment_signature
branch
from
1160f99
to
fd329f1
Compare
maaktweluit
suggested changes
Mar 8, 2021
Previous payment verification method was susceptible to tx hash re-using/stealing attack. A new mechanism has been implemented that requires payment drivers to sign a message with payment details with the same key that has been used to sign the blockchain transaction. Outdated `GetTransactionBalance` endpoint has been replaced with two new endpoints: `SignPayment` and `VerifySignature`. The new endpoints have been implemented in `dummy` and `base` driver crates. Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
Wiezzel
force-pushed
the
wiezzel/payment_signature
branch
from
359068e
to
51f6be7
Compare
|
@maaktweluit Plz, approve again |
maaktweluit
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous payment verification method was susceptible to tx hash re-using/stealing attack. A new mechanism has been implemented that requires payment drivers to sign a message with payment details with the same key that has been used to sign the blockchain transaction.
Outdated
GetTransactionBalanceendpoint has been replaced with two new endpoints:SignPaymentandVerifySignature. The new endpoints have been implemented indummyandbasedriver crates.Task description: PAY-53
Notice:
erc-20has been intentionally omitted because the implementation inbasedriver crate should covert it automatically once it is refactored to use that crate.Testing instructions: Run
invoice_flowanddebit_note_flowwithdummyandzksyncdrivers.