Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed date format. #1338

Merged
merged 10 commits into from
May 31, 2021
Merged

Changed date format. #1338

merged 10 commits into from
May 31, 2021

Conversation

scx1332
Copy link
Collaborator

@scx1332 scx1332 commented May 21, 2021

Resolves #1301

@scx1332 scx1332 force-pushed the log_fix branch 2 times, most recently from 68924d3 to d054c95 Compare May 24, 2021 10:26
@scx1332 scx1332 marked this pull request as ready for review May 24, 2021 10:32
@scx1332 scx1332 requested a review from a team May 24, 2021 10:32
agent/provider/src/provider_agent.rs Outdated Show resolved Hide resolved
core/serv/src/main.rs Outdated Show resolved Hide resolved
if *debug {
env::set_var(
"RUST_LOG",
"debug,tokio_core=info,tokio_reactor=info,hyper=info,reqwest=info",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trust_dns_resolver and trust_dns_proto can still be put on info as well

@tworec tworec changed the base branch from master to release/v0.7 May 31, 2021 13:53
@tworec tworec dismissed nieznanysprawiciel’s stale review May 31, 2021 13:53

The base branch was changed.

Copy link
Collaborator Author

@scx1332 scx1332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I don't see anything weird.
There is change in Windows runner that was not there originally, but I think it is fine. Still there is Goth issue (maybe related to output format change)

Copy link
Contributor

@tworec tworec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tworec tworec merged commit 8013435 into release/v0.7 May 31, 2021
@tworec tworec deleted the log_fix branch May 31, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve log format
4 participants