feat: add support for POST, PUT, DELETE methods #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for POST, PUT, and DELETE methods, and moves to throwing errors and returning objects. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
Updates the simple test example to show more capabilities and interactions. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
tim-golioth
reviewed
Jul 11, 2023
| @@ -90,6 +99,15 @@ func (c *CoAP) client(cc goja.ConstructorCall) *goja.Object { | |||
| if err := client.obj.DefineDataProperty("observe", rt.ToValue(client.Observe), goja.FLAG_FALSE, goja.FLAG_FALSE, goja.FLAG_TRUE); err != nil { | |||
| common.Throw(rt, err) | |||
| } | |||
| if err := client.obj.DefineDataProperty("put", rt.ToValue(client.Put), goja.FLAG_FALSE, goja.FLAG_FALSE, goja.FLAG_TRUE); err != nil { | |||
| common.Throw(rt, err) | |||
There was a problem hiding this comment.
i get it, but it feels so odd to read this in Go code. 😆
There was a problem hiding this comment.
Yeah, ends up being a little easier to work with on the JS side 👍🏻
| // Create new client and connect. | ||
| let client; | ||
| try { | ||
| client = new Client("coap.golioth.io:5684"); |
There was a problem hiding this comment.
If we're going to open source this, should this be pointing to Golioth's production CoAP gateway?
There was a problem hiding this comment.
I think so -- it makes this example real.
There was a problem hiding this comment.
Ok. Given we've got rate-limiting in place, we have some guardrails against a DDOS event.
There was a problem hiding this comment.
Also, someone could mount a DDOS attack whether this code existed or not.
tim-golioth
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for POST, PUT, and DELETE methods, and moves to throwing
errors and returning objects.
Signed-off-by: Daniel Mangum georgedanielmangum@gmail.com