Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: Implement Subfigures #100

Merged
merged 1 commit into from
Sep 2, 2018
Merged

Conversation

miekg
Copy link
Collaborator

@miekg miekg commented Sep 1, 2018

This adds new block syntax that allows you to put multiple figures (or
other block elements) in a larger figure; essentially having subfigures.
Is only enabled when the Mmark extension is on.

The trigger is !--- as it looks like a code block. This also allows
you to set block level attributes on the element.

See https://mmark.nl/post/syntax/#figures-and-subfigures for some extra
wording on the new syntax.

Signed-off-by: Miek Gieben miek@miek.nl

This adds new block syntax that allows you to put multiple figures (or
other block elements) in a larger figure; essentially having subfigures.
Is only enabled when the Mmark extension is on.

The trigger is `!---` as it looks like a code block. This also allows
you to set block level attributes on the element.

See https://mmark.nl/post/syntax/#figures-and-subfigures for some extra
wording on the new syntax.

Signed-off-by: Miek Gieben <miek@miek.nl>
@codecov
Copy link

codecov bot commented Sep 1, 2018

Codecov Report

Merging #100 into master will decrease coverage by 0.18%.
The diff coverage is 69.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   81.83%   81.64%   -0.19%     
==========================================
  Files          20       21       +1     
  Lines        3671     3727      +56     
==========================================
+ Hits         3004     3043      +39     
- Misses        528      537       +9     
- Partials      139      147       +8
Impacted Files Coverage Δ
parser/parser.go 78.4% <100%> (+0.19%) ⬆️
parser/block.go 89.91% <62.5%> (-0.22%) ⬇️
parser/figures.go 70.37% <70.37%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7c02e9...c366cd7. Read the comment docs.

@miekg miekg mentioned this pull request Sep 1, 2018
@miekg miekg merged commit 19f9ca0 into gomarkdown:master Sep 2, 2018
@miekg miekg deleted the subfigures branch September 2, 2018 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant