Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subfigures #1

Closed
miekg opened this issue Jul 31, 2018 · 6 comments
Closed

subfigures #1

miekg opened this issue Jul 31, 2018 · 6 comments
Labels
parser Markdown text is being parsed incorrectly

Comments

@miekg
Copy link
Contributor

miekg commented Jul 31, 2018

Subfigures in mmark are sorta supported by prefixing a paragraph with F> . This is a bit annoying. The scholary markdown (discontinued) solution seems better:

Do this? http://scholarlymarkdown.com/Scholarly-Markdown-Guide.html#floating-env

@miekg miekg added the parser Markdown text is being parsed incorrectly label Aug 26, 2018
@miekg
Copy link
Contributor Author

miekg commented Aug 30, 2018

There is a good discussion here lierdakil/pandoc-crossref#20
It defines a block that gives you a Subfigure env. I don't particular care about subfigures per se, but currently there is no way to wrap a figure into something or add a caption.

@miekg
Copy link
Contributor Author

miekg commented Aug 30, 2018

And this: jgm/pandoc#3177

Defines a block, with !--- as the delimiters

!--- {#foo .right}
![my image](img.jpg)
![second image](img2.jpg)
!---

Which we could re-use, but also allow for single images:

!---
![GitHub Logo](/images/logo.png)
!---
Figure: this is an image

Where Figure makes it captionFigure in the AST and we basically do the same thing as for codeblocks. Other stuff can be put in there as well (crap in, crap out).
We do have to optional Title in the ![Alt text](/path/to/img.jpg "Optional title") image as well to consider.

But I think it is worth while to implement this

@miekg
Copy link
Contributor Author

miekg commented Sep 1, 2018

PR sent: gomarkdown/markdown#100

@mb21
Copy link

mb21 commented Sep 11, 2018

Note that we're still involved in a discussion in how to best implement jgm/pandoc#3177. Feel free to participate :-)

Also, the !--- syntax for pandoc native divs was not implemented, but instead:

::: myClass
![GitHub Logo](/images/logo.png)
:::

@miekg
Copy link
Contributor Author

miekg commented Sep 11, 2018 via email

@miekg
Copy link
Contributor Author

miekg commented Oct 9, 2018

This has been included in mmark

@miekg miekg closed this as completed Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parser Markdown text is being parsed incorrectly
Projects
None yet
Development

No branches or pull requests

2 participants