You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Many events have neither of the three and a toString() call is for example handled by PlayerEvent class, which prints PlayerEvent and not the actual event subclass. Additionally CancellablePlayerEvent and InventoryTransactionEvent as examples are ignoring fields from its super class in its toString().
I suggest removing custom equals and hashCode implementations from events as there is no reason to save and compare event instances.
Also toString() methods should be updated and added to all events to include super class fields like player or entity and cancelled.
The text was updated successfully, but these errors were encountered:
Janmm14
added a commit
to Janmm14/GoMint
that referenced
this issue
Feb 15, 2021
Many events have neither of the three and a
toString()
call is for example handled byPlayerEvent
class, which printsPlayerEvent
and not the actual event subclass. AdditionallyCancellablePlayerEvent
andInventoryTransactionEvent
as examples are ignoring fields from its super class in itstoString()
.I suggest removing custom equals and hashCode implementations from events as there is no reason to save and compare event instances.
Also toString() methods should be updated and added to all events to include super class fields like player or entity and cancelled.
The text was updated successfully, but these errors were encountered: