chore: enable container security contexts modifications #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmehitch
force-pushed
the
chore/security-context
branch
from
20584cc
to
0a844db
Compare
|
Tested in forked repo and release created: https://github.com/jmehitch/athens-charts/releases/tag/athens-proxy-0.8.0 as per contribution guidelines |
DrPsychick
requested changes
Nov 14, 2023
|
Thank you very much for your contribution @jmehitch and your effort in testing the changes, please check my comments. |
jmehitch
force-pushed
the
chore/security-context
branch
from
9695562
to
bf11b02
Compare
|
@DrPsychick thanks for your review and picking up my mistake - was a bad copy & paste in the template 🙂 have updated the PR |
DrPsychick
requested changes
Nov 14, 2023
--- Resolves issue: gomods#49. This commit updates the chart to enable us to override/set additional security context configuration at the container level in each of the containers in the athens-proxy deployment template. It moves the existing `securityContext` configuration to the `PodSecurityContext` at the pod spec level to ensure this isn't a breaking change and ensures backwards compatibility. It adds two new values in the chart `securityContext` (for the main athens container) and `initContainerSecurityContext` (for the init container, if used). This allows us to override/modify the existing configuration with additional security context configuration options in each of the containers, at the container `securityContext` level. See `PodSecurityContext` API reference for fields that can be set at the pod spec level (for the existing `image.runAsNonRoot` configuration): https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.28/#podsecuritycontext-v1-core. And see `SecurityContext` API reference for the fields that can be set at the container spec level: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.28/#securitycontext-v1-core.
jmehitch
force-pushed
the
chore/security-context
branch
from
2b041a1
to
783a11a
Compare
DrPsychick
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue: #49.
This PR updates the chart to enable us to override/set additional security context configuration at the container level in each of the containers in the athens-proxy deployment template.
It moves the existing
securityContextconfiguration to thePodSecurityContextat the pod spec level to ensure this isn't a breaking change and ensures backwards compatibility. It adds two new values in the chartsecurityContext(for the main athens container) andinitContainerSecurityContext(for the init container, if used). This allows us to override/modify the existing configuration with additional security context configuration options in each of the containers, at the containersecurityContextlevel.See
PodSecurityContextAPI reference for fields that can be set at the pod spec level (for the existingimage.runAsNonRootconfiguration): https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.28/#podsecuritycontext-v1-core.And see
SecurityContextAPI reference for the fields that can be set at the container spec level: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.28/#securitycontext-v1-core.closes #49