begin offline mode implementation #1668
Closed
+233
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kunde21
reviewed
Sep 29, 2020
Comment on lines
+129
to
+132
| } else { | ||
| handlerOpts := &download.OfflineHandlerOpts{Logger: l, Storage: s} | ||
| download.RegisterOfflineHandlers(r, handlerOpts) | ||
| } |
There was a problem hiding this comment.
Drive-by look, but this could be:
if c.Mode == config.ModeOffline {
handlerOpts := &download.OfflineHandlerOpts{Logger: l, Storage: s}
download.RegisterOfflineHandlers(r, handlerOpts)
return nil
}
// online handling
Open
|
Solved by: #1717 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
In a few places like #1532, people have asked for a mode of Athens that never hits the internet (the current one will hit the internet in various circumstances).
How is the fix applied?
I began adding support for a mode in Athens that just reads from storage, not any upstream or anywhere else.
What GitHub issue(s) does this PR fix or close?
Ref #1532