Fix K8s service account usage #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arschles
approved these changes
Oct 22, 2020
|
oops @owenhaynes the helm chart version needs an increase, then this is all good to go |
|
@arschles done |
|
I have a feeling that everyone forgot about this PR? |
|
Apologies, this PR fell off of my GitHub notifications. The CI failure on this PR looks to be a flake, so I've restarted it and if it passes, I will merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
For the K8s service account to be used in the deployment, fix legacy resource, and allow annotations on service account.
How is the fix applied?
added the service account to the deployment
What GitHub issue(s) does this PR fix or close?