Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set GO111MODULE to auto in golint script– #1743 #1744

Merged
merged 3 commits into from
Dec 10, 2021
Merged

Set GO111MODULE to auto in golint script– #1743 #1744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4572813
Set GO111MODULE to auto in golint script– #1743
rbrtl Dec 9, 2021
61017a8
Remove redundant code – golint script
rbrtl Dec 10, 2021
d76ace1
Replace `golint` with `go vet`
rbrtl Dec 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ setup-dev-env:
.PHONY: verify
verify: ## verify athens codebase
./scripts/check_gofmt.sh
./scripts/check_golint.sh
./scripts/check_govet.sh
./scripts/check_deps.sh
./scripts/check_conflicts.sh

Expand Down
11 changes: 7 additions & 4 deletions pkg/stash/with_etcd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,13 @@ func WithEtcd(endpoints []string, checker storage.Checker) (Wrapper, error) {
}
var eg errgroup.Group
for _, ep := range endpoints {
eg.Go(func() error {
_, err := c.Status(ctx, ep)
return err
})
epStat := func(ep string) func() error {
return func() error {
_, err := c.Status(ctx, ep)
return err
}
}(ep)
eg.Go(epStat)
}
err = eg.Wait()
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion scripts/check_golint.sh → scripts/check_govet.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
# Run the linter on everything except generated code
set -euo pipefail

golint -set_exit_status $(GO111MODULE=off go list ./... | grep -v '/mocks')
go vet ./...