-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue 106 secure secrets storing #110
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonczor
force-pushed
the
issue-106-secure-secrets-storing
branch
2 times, most recently
from
April 11, 2021 20:22
2be396b
to
39d897d
Compare
gonczor
force-pushed
the
issue-106-secure-secrets-storing
branch
from
April 11, 2021 20:22
39d897d
to
2472a27
Compare
gonczor
commented
Apr 11, 2021
gonczor
commented
Apr 11, 2021
src/settings/secrets/retrievers/environment_variables_retriever.py
Outdated
Show resolved
Hide resolved
Overall: it might be a good idea to store all of the vars in SSM and pull them all the time? This way I won't have to update 2 separate task definitions in ECS. |
gonczor
commented
Apr 11, 2021
gonczor
force-pushed
the
issue-106-secure-secrets-storing
branch
from
April 17, 2021 09:14
b1ee46f
to
e045022
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #106