Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 106 secure secrets storing #110

Merged
merged 8 commits into from
Apr 17, 2021
Merged

Conversation

gonczor
Copy link
Owner

@gonczor gonczor commented Apr 11, 2021

  • Basic get_secret function
  • Define BaseSecretsRetriever abstract class
  • Implement AWS SSM secrets retriever
  • Implement environment variables secrets retriever
  • Create Retriever factory
  • Retrieve secrets using dedicated retriever class

closes #106

@gonczor gonczor force-pushed the issue-106-secure-secrets-storing branch 2 times, most recently from 2be396b to 39d897d Compare April 11, 2021 20:22
@gonczor gonczor force-pushed the issue-106-secure-secrets-storing branch from 39d897d to 2472a27 Compare April 11, 2021 20:22
@gonczor
Copy link
Owner Author

gonczor commented Apr 11, 2021

Overall: it might be a good idea to store all of the vars in SSM and pull them all the time? This way I won't have to update 2 separate task definitions in ECS.

@gonczor gonczor force-pushed the issue-106-secure-secrets-storing branch from b1ee46f to e045022 Compare April 17, 2021 09:14
@gonczor gonczor merged commit e1877ce into master Apr 17, 2021
@gonczor gonczor deleted the issue-106-secure-secrets-storing branch April 17, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store Secrets with Secrets Manager
1 participant