Skip to content

Commit

Permalink
Putting code comments in place to capture my current thoughts on gaps…
Browse files Browse the repository at this point in the history
… in the design.
  • Loading branch information
James Dennis committed Jan 12, 2012
1 parent 2aefd25 commit 4f68b6e
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion brubeck/request_handling.py
Expand Up @@ -802,6 +802,10 @@ def uri_for_shield(self, shield):
### HTTP methods
###

### Section TODO:
### * Cleaner handling of list vs single
### * Clean handling of how status info is or isn't used

def get(self, ids=""):
"""Handles read - either with a filter (ids) or a total list
"""
Expand Down Expand Up @@ -914,11 +918,16 @@ def delete(self, ids):
### CRUD operations
###

### Section TODO:
### * Pagination
### * Hook in authentication
### * Key filtering (owner / public)
### * Make model instantiation an option

def read(self, ids):
"""Returns a list of shields in the db. Takes a list of object ids to
include - if that's empty then include everything.
"""
### TODO: pagination
query_data = self.queries.read(ids)

if ids and not query_data:
Expand Down

0 comments on commit 4f68b6e

Please sign in to comment.