-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Worms Armageddon one pixel garbage line under names and menu items #1847
Conversation
There is no garbage line if gSP.bgImage.height is always imageH - 1. I also replaced imageW modulo operation with & 0xFFFFFFFE.
gSP.bgImage.width = imageW - imageW%2; | ||
gSP.bgImage.height = imageH - imageH%2; | ||
gSP.bgImage.width = imageW & 0xFFFFFFFE; | ||
gSP.bgImage.height = imageH - 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose that imageH - imageH%2 was done for purpose.
imageH & 0xFFFFFFFE
would cause no questions.
I'm afraid that imageH - 1
will cause regressions. I need to test it first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gonetz
There can be regressions but i have seen none. I have tested beetle adventure racing, sm64, mario tennis, smash bros, paper mario, yoshis story, mischief makers, bomberman and many other games, re2, doom, mario kart and goldeneye.
Does it work ok in lle? |
@olivieryuyu |
this is a HLE issue as in LLE not such an issue. I am working on the ucode (slowly but surely, i will take my time on this) but from there a proper fix should be found for all games with S2DEX errors. |
I wonder if this is related to the issue I’m seeing in F-zero with the mph numbers showing up at the bottom of the texture. |
Is there a binary available so I can test the changes? |
Mario Tennis pause menu also has a garbage line. I'm sure I've seen this in other games too, but Mario Tennis is the only one that comes to my mind. |
Mario Kart 64 has a garbage line to the right of the split screen race finish screen (on master. Dont know if this PR affects it.) |
@theboy181 @olivieryuyu @gonetz
Quite interesting. Do we ned more than one fill up texel if imageSiz is G_IM_SIZ_16b, G_IM_SIZ_8b or G_IM_SIZ_4b? I can write my PR a little bit different to get the same result: |
I have found more information:
So if modulo operation is there to calculate the right imageW it is not necessary to correct imageH. |
this issue did not exit in Sep 2017. It is a new one. Seems we are turning around an issue... |
@olivieryuyu if it is a regression i could try to bisect the commit which changes behaviour. |
it was not here in September 2017. I guess something happened after. |
I will close this for now. I get equal or better results if i revert above mentioned commit and modify ObjCoordinates creation. |
There is a one pixel garbage line under every menu item and under every worm name . If gSP.bgImage.height is imageH - 1 there is no garbage. I have tested this fix with multiple games and have not seen any regression.
I also replaced imageW modulo operation with & 0xFFFFFFFE.