lapack: add BalanceJob type, remove Job and Comp types #572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dgebal
andDgebak
are the only remaining functions that use the genericJob
type. This PR adds a dedicatedBalanceJob
type and removes theJob
andComp
types. This breaks the netlib/lapack packages, a follow-up PR to do the necessary changes there is ready.Updates #570
Updates gonum/lapack#163
It is only an update because:
There is still the genericComp
typeNone
constant for each type. There areSVDNone
andGSVDNone
for SVD but no such constants for eigenvalues. It is probably better to add the missing constants so that it is clear which types allow theNone
option. Opinions?Please take a look.