Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lapack: add BalanceJob type, remove Job and Comp types #572

Merged
merged 3 commits into from
Aug 21, 2018

Conversation

vladimir-ch
Copy link
Member

@vladimir-ch vladimir-ch commented Aug 20, 2018

Dgebal and Dgebak are the only remaining functions that use the generic Job type. This PR adds a dedicated BalanceJob type and removes the Job and Comp types. This breaks the netlib/lapack packages, a follow-up PR to do the necessary changes there is ready.

Updates #570
Updates gonum/lapack#163

It is only an update because:

  1. There is still the generic Comp type
  2. I'm not sure whether we need a dedicated None constant for each type. There are SVDNone and GSVDNone for SVD but no such constants for eigenvalues. It is probably better to add the missing constants so that it is clear which types allow the None option. Opinions?
  3. I want to review the names; after a quick look (G)SVD jobs use (G)SVD as a prefix, EV jobs use EV as a suffix, ...

Please take a look.

@vladimir-ch vladimir-ch changed the title lapack: add BalanceJob type, remove Job type lapack: add BalanceJob type, remove Job and Comp types Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants