bound: Add Union helper for bound package #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kortschak
requested changes
Apr 18, 2019
corona10
force-pushed
the
gh-939-union
branch
2 times, most recently
from
1b1c557
to
4fc07a2
Compare
corona10
commented
Apr 18, 2019
| b3 := Bound{Min: 1.0, Max: 2.0} | ||
| b4 := Bound{Min: 1.1, Max: 2.0} | ||
|
|
||
| ret := Union(b0) |
There was a problem hiding this comment.
Shall I update this one also into union := Union(b0)?
My intent was the return value VS expected value for testing.
There was a problem hiding this comment.
You can leave the tests. We usually use got for test results, but this will be rewritten to use tables.
|
@kortschak Please take a look! |
kortschak
reviewed
Apr 18, 2019
|
@kortschak I've updated the CL. Please take a look |
kortschak
approved these changes
Apr 18, 2019
|
Is this function right? If we have [[0, 1], [2, 3], [0.5, 2.5]] this has a valid union of [0,3] but this algorithm will return NaN as far as I can see |
|
I'll add that to the tests I'm going to write in the next couple of hours and fix it up. It needs to sort the bounds first and then walk them. Thanks for pointing it out. This is why I always use trees for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Union helper for bound package
Updates: #939