This repository has been archived by the owner on Apr 26, 2019. It is now read-only.
{search,traverse}: clean up after recent changes #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factor common types out into new graph/internal package.
This sort order was a lazy solution to sorting [][]int, so remove it.
Also remove unused remove method on johnsonGraph which was left over from the implementation in gonum/plot/plotter.
|
ping @gonum/developers |
| @@ -398,6 +400,34 @@ func TestTarjanSCC(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| // batageljZaversnikGraph is the example graph from | |||
There was a problem hiding this comment.
Is it worth having an 'example graphs' package in internal so that way we only need to implement this once?
There was a problem hiding this comment.
Or possibly not in internal if we want to expose some easy examples (like in optimize)
There was a problem hiding this comment.
I'm happy to do that in a later change (I think that this has merit for a number of reasons - including as a teaching resource), but I'd like to just get the place clean first.
I'll file an issue.
|
Code changes LGTM except for the one comment on the example graphs. |
|
|
||
| package internal | ||
|
|
||
| // A set is a set of integer identifiers. |
There was a problem hiding this comment.
A set -> IntSet
And capital letters in the comments below.
|
Also LGTM |
kortschak
added a commit
that referenced
this pull request
May 12, 2015
{search,traverse}: clean up after recent changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add internal package for (most) shared unexported types and factor test example graphs into named values.