mat64: reverse signatures for decomposition matrix extractions #436
Conversation
Why the "To" endings? It seems like |
There are two usage syntaxes, |
I'll wait for @btracey to make sure he's happy with my argument above. |
Thinking about it, I think the related argument is that usually the receiver is modified. This is a difference, so that difference should be clear. |
LGTM |
This is a pretty big breaking change, at least for code I've written. Is it possible we could merge repos into gonum/gonum and then make this change? It sounds like there's nothing in the way of migration that will change. |
I'm happy to wait. This is relatively small and I'll just copy past over to the new location when we are ready if that's what you want. |
Curious though. How does delaying the merge of this help? |
My suggestion was that this is a (decent-sized) breaking change, and it might be nice to delay that until the merge. This way, old code can remain working without update. |
Done in gonum/gonum. |
Also provides some sugar to ease this.
@btracey @vladimir-ch Please take a look.
Closes #435.