This repository has been archived by the owner on Dec 22, 2018. It is now read-only.
stat: use the updated decomposition extraction API #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimir-ch
reviewed
Mar 22, 2017
| } else if d, n := dst.Dims(); (n != 0 || d != 0) && (d != c.d || n != min(c.n, c.d)) { | ||
| panic(matrix.ErrShape) | ||
| if dst != nil { | ||
| if d, n := dst.Dims(); (n != 0 || d != 0) && (d != c.d || n != min(c.n, c.d)) { |
There was a problem hiding this comment.
:) This is an intentionally left sore to provoke the exporting of IsZero in mat64.
| } else if d, n := dst.Dims(); (n != 0 || d != 0) && (n != c.yd || d != c.xd) { | ||
| panic(matrix.ErrShape) | ||
| if dst != nil { | ||
| if d, n := dst.Dims(); (n != 0 || d != 0) && (n != c.yd || d != c.xd) { |
| } else if d, n := dst.Dims(); (n != 0 || d != 0) && (n != c.yd || d != c.yd) { | ||
| panic(matrix.ErrShape) | ||
| if dst != nil { | ||
| if d, n := dst.Dims(); (n != 0 || d != 0) && (n != c.yd || d != c.yd) { |
|
I left |
|
Yea, I think they should change. Consistent naming is best for everyone. |
Also propagate the `dst := x.PTo(y)` idiom to stat.
kortschak
force-pushed
the
reverse-extraction
branch
from
528411d
to
0b62c97
Compare
6 tasks
|
This has been done in gonum/gonum. |
|
Ooops. No it hasn't. |
|
It looks like this happened in the other repo. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have left the CC methods
LeftandRightas they are rather than renaming toLeftToandRightTo, which they probably should be changed to.@btracey @vladimir-ch Please take a look.
Depends on gonum/matrix#436.