Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple initialization based configuration support and the ability to configure if the sign in is stored in the session #22

Closed
wants to merge 3 commits into from

Conversation

krsyoung
Copy link
Contributor

@krsyoung krsyoung commented Feb 2, 2014

This PR includes a feature that @gonzalo-bulnes has identified in issue #19 (and could possibly help with #20 and #12).

  1. Initial configuration framework to support an initializer based configuration file
  2. A single configuration to define if the token authentication should be stored in the session (i.e. can the user navigate to other pages as an authenticated user after a single token authentication).

I have included updates to the documentation however no test cases :(

@gonzalo-bulnes please let me know if it helps if I break these up more cleanly between issues #19 and #20. Thanks!

@gonzalo-bulnes
Copy link
Owner

Hi @krsyoung! I cherry-picked your code from #32 in order to take advantage of the @joel improvements (see #23) and, since the branch is merged I'll close both PR.

Many thanks to both of you for this configuration framework!

@krsyoung Since you asked about the RSpec test cases: I've deeply refactored the Cucumber "dummy apps generation framework" and I believe it became a lot more readable. Take a look at the doc/features.html file to see how the RSpec use cases are build : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants