Enable mongoid adapter to be used with rails 6.0 #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Seems correct to me! @unused
Can you amend you commit to add the header to the change log please, and I think with that we'd be good to go! 💯
Note: rails 6.0 require mongoid > 7.0.5
|
Thank you very much for your PR @unused. It may seem like a small thing but to me it makes a huge difference. I just released your changes in v1.17.0 🎉 : ) |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts changes from 0c1a9a5 and allows simple_token_authentication to be used with rails 6.0. With mongoid version 7.0.5 rails 6.0 support was added.
Fixes #351 #352