Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the Sharpness aware minimization docstring #834

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Fixed the Sharpness aware minimization docstring #834

merged 4 commits into from
Feb 29, 2024

Conversation

hmludwig
Copy link
Contributor

Fixed the docstring such that it gets displayed correctly (see #826)

Screenshot 2024-02-29 at 12 22 58

Copy link
Member

@fabianp fabianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! Minor formatting suggestions :-)

optax/contrib/sam.py Outdated Show resolved Hide resolved
optax/contrib/sam.py Outdated Show resolved Hide resolved
optax/contrib/sam.py Outdated Show resolved Hide resolved
hmludwig and others added 3 commits February 29, 2024 12:50
Co-authored-by: Fabian Pedregosa <pedregosa@google.com>
Co-authored-by: Fabian Pedregosa <pedregosa@google.com>
Co-authored-by: Fabian Pedregosa <pedregosa@google.com>
@hmludwig
Copy link
Contributor Author

Thanks for the suggestions. I adopted them :)

@fabianp
Copy link
Member

fabianp commented Feb 29, 2024

amazing, let's get this merged! 🚀

@hmludwig
Copy link
Contributor Author

I accidentally pushed to the wrong branch. It seems my reset messed things up. Sorry for that.

@fabianp
Copy link
Member

fabianp commented Feb 29, 2024

no worries, we can easily get the original code

@copybara-service copybara-service bot merged commit 259a6ea into google-deepmind:main Feb 29, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants