Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Embeddings.ipynb to show
output_dimenstionality
parameter. #82base: main
Are you sure you want to change the base?
Update Embeddings.ipynb to show
output_dimenstionality
parameter. #82Changes from all commits
60bf255
2246841
62bc6e8
9acd707
cb5cbdd
26ceaba
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds like this change is to add this parameter but it's hidden in this code snippet comparing task types without explanation.
Maybe add a section after this block with a short note? e.g.:
Can we talk about the relationship between the index and specificity? It'd be great to add a statement like "When using
text-embedding-004
, each dimension adds diminishing value so truncating may be effective in constrained environments ." - but I haven't verified if this is true.Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markmcd I haven't verified it either but I think it would be a great add! @MarkDaoust what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use
output_dimensionality=4
hereInclude a comment explaining it.
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(That way you wouldn't need the '... trimmed')