Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Domain-Wide Delegation #70

Merged
merged 3 commits into from
Dec 2, 2021
Merged

Add support for Domain-Wide Delegation #70

merged 3 commits into from
Dec 2, 2021

Conversation

sethvargo
Copy link
Member

No description provided.

@sethvargo sethvargo requested a review from a team as a code owner December 1, 2021 23:07
@google-cla google-cla bot added the cla: yes label Dec 1, 2021
Copy link
Contributor

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we add an integration test to make sure future/upstream changes wont break this flow?

src/utils.ts Outdated Show resolved Hide resolved
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
@sethvargo
Copy link
Member Author

LGTM, should we add an integration test to make sure future/upstream changes wont break this flow?

I would love to - I tested this in a private fork. The problem is that, since the integration tests are in the google.com org, there's no way we can enable DWD 😦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants