Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENV var key value paring in 2.3.0 critical bug #503

Closed
scottravio opened this issue Apr 10, 2024 · 1 comment · Fixed by #504
Closed

ENV var key value paring in 2.3.0 critical bug #503

scottravio opened this issue Apr 10, 2024 · 1 comment · Fixed by #504
Labels
bug Something isn't working

Comments

@scottravio
Copy link

TL;DR

bug introduced here: #496

The KV parser creates a delimiter string which does not exist in the input string. This can cause an error when an env var value ends with the start of the delim string.

For instance, if a delim string is dd and I have an ENV var SOMETHING=hello-world SOMETHING_ELSE=foo, the string ends up like SOMETHING=hello-worldddSOMETHING_ELSE=foo, which creates cloud run ENV variables:

SOMETHING=hello-worl
dSOMETHING_ELSE=foo

Expected behavior

ENV variables correctly parsed

Observed behavior

No response

Action YAML

N/A

Log output

No response

Additional information

No response

@njhartwell
Copy link

njhartwell commented May 14, 2024

This is still an issue when concatenating the value and delimiter results produces a new occurrence of the delimiter. It's presumably uncommon, but I just saw it happen in the wild.

e.g. for the label commit-sha=xxxx524 and the delimiter 5245

^5245^commit-sha=xxxx5245245ref-name=main

yields 245ref-name=main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants