-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENV var key value paring in 2.3.0 critical bug #503
Labels
bug
Something isn't working
Comments
sethvargo
added a commit
to google-github-actions/actions-utils
that referenced
this issue
Apr 11, 2024
sethvargo
added a commit
to google-github-actions/actions-utils
that referenced
this issue
Apr 11, 2024
sethvargo
added a commit
that referenced
this issue
Apr 15, 2024
This is still an issue when concatenating the value and delimiter results produces a new occurrence of the delimiter. It's presumably uncommon, but I just saw it happen in the wild. e.g. for the label
yields |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TL;DR
bug introduced here: #496
The KV parser creates a delimiter string which does not exist in the input string. This can cause an error when an env var value ends with the start of the delim string.
For instance, if a delim string is
dd
and I have an ENV var SOMETHING=hello-world SOMETHING_ELSE=foo, the string ends up likeSOMETHING=hello-worldddSOMETHING_ELSE=foo
, which creates cloud run ENV variables:Expected behavior
ENV variables correctly parsed
Observed behavior
No response
Action YAML
N/A
Log output
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: