Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new helper to compile KV string #496

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Use new helper to compile KV string #496

merged 1 commit into from
Mar 28, 2024

Conversation

sethvargo
Copy link
Member

@sethvargo sethvargo commented Mar 28, 2024 •
edited
Loading

This requires changing the test inputs to expect JSON instead of K=V pairs in our e2e runner.

@sethvargo sethvargo requested a review from a team as a code owner March 28, 2024 14:03
@sethvargo sethvargo force-pushed the sethvargo/test branch 3 times, most recently from 3b0d0da to 9366c83 Compare March 28, 2024 14:15
@sethvargo sethvargo changed the title Add test for complex envvars with special characters Use new helper to compile KV string Mar 28, 2024
@sethvargo sethvargo force-pushed the sethvargo/test branch 3 times, most recently from 488a5c8 to 5fd6dd4 Compare March 28, 2024 14:41
@sethvargo
Add test for complex envvars with special characters
f98a323 
This requires changing the test inputs to expect JSON instead of K=V pairs in our e2e runner.
@sethvargo sethvargo merged commit 68504f3 into main Mar 28, 2024
9 checks passed
@sethvargo sethvargo deleted the sethvargo/test branch March 28, 2024 15:01
@google-github-actions-bot google-github-actions-bot mentioned this pull request Mar 28, 2024
Merged
sethvargo pushed a commit that referenced this pull request Mar 28, 2024
@google-github-actions-bot
Release: v2.3.0 (#499)
cfda0c0 
## What's Changed
* security: bump undici from 5.28.2 to 5.28.3 by @dependabot in
#489
* Use new helper to compile KV string by @sethvargo in
#496
* Document how set traffic to the latest revision by @sethvargo in
#498


**Full Changelog**:
v2.2.0...3a6ddb2
@scottravio scottravio mentioned this pull request Apr 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verbanicm verbanicm Awaiting requested review from verbanicm verbanicm is a code owner automatically assigned from google-github-actions/maintainers

@averikitsch averikitsch Awaiting requested review from averikitsch averikitsch is a code owner automatically assigned from google-github-actions/maintainers

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

env vars with commas in value do not work Document about environment variable escaping
1 participant
@sethvargo