Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for jobs. #474

Closed

Conversation

scstorytel
Copy link
Contributor

Revisiting #422 to add support for jobs.
These are the same set of changes.

Tests all pass for node 16, ran using npm test.

@scstorytel scstorytel requested a review from a team as a code owner November 7, 2023 10:07
@scstorytel scstorytel changed the title Add support for jobs. feat: Add support for jobs. Nov 7, 2023
@scstorytel
Copy link
Contributor Author

Hello @sethvargo,

Do you need me to rebuild/retest this for Node 20?

@nick-youngblut
Copy link

Any updates on this? It would be great to have support for Cloud Run jobs.

@banderson623
Copy link

This would be pretty great to add 👍

@braveenth
Copy link

@atrauzzi
Copy link

@sethvargo @averikitsch -- Is there any chance this or #422 can be moved forward? Would really like to be able to get up and running with it! 🙂

@iennae
Copy link
Member

iennae commented Mar 27, 2024

@scstorytel could you resolve the currently conflicting files? I can take a look after that. Thanks.

@scstorytel
Copy link
Contributor Author

@iennae I've updated the jobs tests and built the new version. Have a look and lmk if it all looks good please.

# Conflicts:
#	dist/main/index.js
#	package-lock.json
@scstorytel
Copy link
Contributor Author

@iennae Updated everything again. This might be my inexperience with javascript speaking, but maybe we should not track things like package-lock.json, since that's just a generated file that tells you what you have installed? Same with index.js, since that's just the build output. It seems to create unnecessary/redundant conflicts.

@TigerC10
Copy link

@scstorytel we do want to track package-lock.json because it pins the versions of 3rd party dependencies installed. The package.json can specify version numbers in the form ^6.0.0 which would indicate "anything compatible with 6.0.0" rather than the specific 6.0.0 versioned release. The package-lock will specify which exact version was installed.

sethvargo added a commit that referenced this pull request Apr 15, 2024
Closes #474

Closes #364

---------

Co-authored-by: stephanos.charalambous <stephanos.charalambous@storytel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants