-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for jobs. #474
feat: Add support for jobs. #474
Conversation
Hello @sethvargo, Do you need me to rebuild/retest this for Node 20? |
Any updates on this? It would be great to have support for Cloud Run jobs. |
This would be pretty great to add 👍 |
+1 Added support for Jobs yaml here: https://github.com/braveenth/deploy-cloudrun/tree/add-cloud-run-job-yaml-support |
@sethvargo @averikitsch -- Is there any chance this or #422 can be moved forward? Would really like to be able to get up and running with it! 🙂 |
@scstorytel could you resolve the currently conflicting files? I can take a look after that. Thanks. |
…upport-for-jobs # Conflicts: # dist/main/index.js
@iennae I've updated the jobs tests and built the new version. Have a look and lmk if it all looks good please. |
# Conflicts: # dist/main/index.js # package-lock.json
@iennae Updated everything again. This might be my inexperience with javascript speaking, but maybe we should not track things like package-lock.json, since that's just a generated file that tells you what you have installed? Same with index.js, since that's just the build output. It seems to create unnecessary/redundant conflicts. |
@scstorytel we do want to track |
Revisiting #422 to add support for jobs.
These are the same set of changes.
Tests all pass for node 16, ran using
npm test
.