Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD] Sync main with HEAD #6

Closed
wants to merge 3 commits into from
Closed

[HOLD] Sync main with HEAD #6

wants to merge 3 commits into from

Conversation

JeromeJu
Copy link
Contributor

@JeromeJu JeromeJu commented May 6, 2024

This commit syncs up main with HEAD at release-v0.1.x.

sethvargo and others added 3 commits April 16, 2024 21:14
@sethvargo
Update CODEOWNERS (#3)
1060cf7
@JeromeJu
feat: init deploy-gke Container Action (#5)
b0872d9 
This commit inits the deploy-gke container action. It utlizes the
gke-deploy CLI image to deploy an existing image to a GKE cluster.

The integration test, documentation and CI setup are included within
this initial commit.

<!--
Thank you for proposing a pull request! Please note that SOME TESTS WILL
LIKELY FAIL due to how GitHub exposes secrets in Pull Requests from
forks.
Someone from the team will review your Pull Request and respond.

Please describe your change and any implementation details below.
-->
@JeromeJu
feat: init deploy-gke Container Action (#2)
07f7b4e 
This commit inits the deploy-gke container action. It utlizes the
gke-deploy CLI image to deploy an existing image to a GKE cluster.

The integration test, documentation and CI setup are included within
this initial commit.

<!--
Thank you for proposing a pull request! Please note that SOME TESTS WILL
LIKELY FAIL due to how GitHub exposes secrets in Pull Requests from
forks.
Someone from the team will review your Pull Request and respond.

Please describe your change and any implementation details below.
-->

Signed-off-by: JeromeJu <46675578+JeromeJu@users.noreply.github.com>
@JeromeJu JeromeJu requested a review from a team as a code owner May 6, 2024 23:31
@JeromeJu JeromeJu closed this May 6, 2024
@JeromeJu
Copy link
Contributor Author

JeromeJu commented May 6, 2024 •
edited

This PR shall be merged to update main with HEAD once #7 is merged. I will rebase this PR after #7 so that we have the expected main to get to release.

/hold

On second thought I've opened #8 at fix/main branch which could be less confusing.

@JeromeJu JeromeJu reopened this May 6, 2024
@JeromeJu JeromeJu changed the title Sync main with HEAD [HOLD] Sync main with HEAD May 6, 2024
@JeromeJu JeromeJu closed this May 6, 2024
@sethvargo sethvargo deleted the release-v0.1.x branch May 7, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethvargo sethvargo Awaiting requested review from sethvargo sethvargo is a code owner automatically assigned from google-github-actions/maintainers

@verbanicm verbanicm Awaiting requested review from verbanicm verbanicm is a code owner automatically assigned from google-github-actions/maintainers

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JeromeJu @sethvargo