Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] Sync main with HEAD #6

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ jobs:
cluster_name: '${{ vars.CLUSTER_NAME }}'
project_id: '${{ vars.PROJECT_ID }}'
namespace: '${{ vars.NAMESPACE }}'
expose: '${{ vars.EXPOSE }}'

- name: 'get credentials'
uses: 'google-github-actions/get-gke-credentials@v2'
Expand Down
3 changes: 2 additions & 1 deletion CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
* @google-github-actions/maintainers
* @google-github-actions/maintainers
* @google-github-actions/deploy-gke-maintainers
3 changes: 2 additions & 1 deletion entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#!/bin/sh -l

gha_version="0.1.0"
gke_deploy_command="gke-deploy run -i $image -a $app_name -l $location -c $cluster_name -p $project_id"

image="$1"
app_name="$2"
Expand All @@ -25,6 +24,8 @@ project_id="$5"
namespace="$6"
expose_port="$7"

gke_deploy_command="gke-deploy run -i $image -a $app_name -l $location -c $cluster_name -p $project_id"

# Ensure all required variables are provided by workflow users.
if [ -z "$image" ] || [ -z "$app_name" ] || [ -z "$location" ] || [ -z "$cluster_name" ] || [ -z "$project_id" ]; then
echo "Error: Required variables (image, app_name, location, cluster_name, project_id) are not set."
Expand Down