Skip to content

Commit

Permalink
CoRL bibtex update.
Browse files Browse the repository at this point in the history
  • Loading branch information
kevinzakka committed Sep 7, 2023
1 parent eee53aa commit 2809e74
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 9 deletions.
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# RoboPianist: A Benchmark for High-Dimensional Robot Control
# RoboPianist: Dexterous Piano Playing with Deep Reinforcement Learning

[![build][tests-badge]][tests]
[![docs][docs-badge]][docs]
Expand Down Expand Up @@ -126,10 +126,10 @@ See [docs/faq.md](docs/faq.md) for a list of frequently asked questions.
If you use RoboPianist in your work, please use the following citation:

```bibtex
@article{zakka2023robopianist,
author = {Zakka, Kevin and Smith, Laura and Gileadi, Nimrod and Howell, Taylor and Peng, Xue Bin and Singh, Sumeet and Tassa, Yuval and Florence, Pete and Zeng, Andy and Abbeel, Pieter},
title = {{RoboPianist: A Benchmark for High-Dimensional Robot Control}},
journal = {arXiv preprint arXiv:2304.04150},
@inproceedings{robopianist2023,
author = {Zakka, Kevin and Wu, Philipp and Smith, Laura and Gileadi, Nimrod and Howell, Taylor and Peng, Xue Bin and Singh, Sumeet and Tassa, Yuval and Florence, Pete and Zeng, Andy and Abbeel, Pieter},
title = {RoboPianist: Dexterous Piano Playing with Deep Reinforcement Learning},
booktitle = {Conference on Robot Learning (CoRL)},
year = {2023},
}
```
Expand Down
4 changes: 4 additions & 0 deletions robopianist/models/piano/midi_module.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ def after_substep(
activation: np.ndarray,
sustain_activation: np.ndarray,
) -> None:
# Sanity check dtype since we use bitwise operators.
assert activation.dtype == bool
assert sustain_activation.dtype == bool

timestep_events: List[midi_message.MidiMessage] = []
message: midi_message.MidiMessage

Expand Down
6 changes: 2 additions & 4 deletions robopianist/models/piano/piano.py
Original file line number Diff line number Diff line change
Expand Up @@ -186,10 +186,8 @@ def _update_key_state(self, physics: mjcf.Physics) -> None:
joints_pos = physics.bind(self.joints).qpos
self._state[:] = np.clip(joints_pos, *self._qpos_range.T)
self._normalized_state[:] = self._state / self._qpos_range[:, 1]
self._activation[:] = np.where(
np.abs(self._state - self._qpos_range[:, 1]) <= _KEY_THRESHOLD,
1.0,
0.0,
self._activation[:] = (
np.abs(self._state - self._qpos_range[:, 1]) <= _KEY_THRESHOLD
)
self._sustain_activation[:] = self._sustain_state >= _SUSTAIN_THRESHOLD

Expand Down

0 comments on commit 2809e74

Please sign in to comment.