-
Notifications
You must be signed in to change notification settings - Fork 620
afl: Fix afl-qemu build by applying new patches #79
Conversation
These patches are gathered from different sources, see also below. The other patch is required because some implicitly included files are not included anymore, requiring an explicit include of <linux/sockios.h>. This solves issue google#41. Build errors include: SIOCGSTAMP not declared, SIOCGSTAMPNS not declared and `static declaration of ‘gettid’ follows non-static declaration` See also: - qemu/qemu@71ba74f - qemu/qemu@6d5d5dd - https://lkml.org/lkml/2019/6/3/988 - https://patchwork.kernel.org/patch/10862231/
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
I doubt you will get this approved as these patches were not written by you hence you can not accept the google legal stuff on the authors’ patches behalf
|
You're right. I'll close this. |
Ultimately, this patch is adding one include file and renaming gettid to sys_gettid. I don't think that should give any issues with ownership. But we'll see. |
These patches are gathered from different sources, such as https://patchwork.kernel.org/patch/10862231/ for the `gettid` patch. Another patch comes from the issue in the AFL repository. The ultimate goal is to get these patches upstream as well, so we don't keep these general patches only within nixos. A PR is created against Google/AFL google/AFL#79, but it might take a while before it's landed, considering the history of the project (there are more PRs open). ZHF: NixOS#80379 Fixes issue NixOS#82232
These patches are gathered from different sources, such as https://patchwork.kernel.org/patch/10862231/ for the `gettid` patch. Another patch comes from the issue in the AFL repository. The ultimate goal is to get these patches upstream as well, so we don't keep these general patches only within nixos. A PR is created against Google/AFL google/AFL#79, but it might take a while before it's landed, considering the history of the project (there are more PRs open). ZHF: NixOS#80379 Fixes issue NixOS#82232
These patches are gathered from different sources, such as https://patchwork.kernel.org/patch/10862231/ for the `gettid` patch. Another patch comes from the issue in the AFL repository. The ultimate goal is to get these patches upstream as well, so we don't keep these general patches only within nixos. A PR is created against Google/AFL google/AFL#79, but it might take a while before it's landed, considering the history of the project (there are more PRs open). ZHF: #80379 Fixes issue #82232
These patches are gathered from different sources, such as https://patchwork.kernel.org/patch/10862231/ for the `gettid` patch. Another patch comes from the issue in the AFL repository. The ultimate goal is to get these patches upstream as well, so we don't keep these general patches only within nixos. A PR is created against Google/AFL google/AFL#79, but it might take a while before it's landed, considering the history of the project (there are more PRs open). ZHF: #80379 Fixes #82232
qemu still doesn't build itself with the build_qemu_support.sh script.. EDIT: I have another issue with this patch (user/syscall.c:8166: undefined reference to `stime') |
It would be nice indeed. If you're looking for an alternative, you could look at https://github.com/aflplusplus/aflplusplus. |
Let's close this, I guess this is not according CLA anyway. |
These patches are gathered from different sources,
see also below.
The other patch is required because some implicitly included
files are not included anymore, requiring an explicit include
of <linux/sockios.h>.
This solves issue #41.
Build errors include: SIOCGSTAMP not declared,
SIOCGSTAMPNS not declared and
static declaration of ‘gettid’ follows non-static declaration
See also:
It would be great if someone could verify this (or help me verify it), I'm not using the qemu build.
Main goal is to make sure afl keeps building in the NixOS repositories for anyone that wants to be able to use the QEMU mode.