Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlaybackControlView leaks itself and anything it refers to (including the player instance) #1908

Closed
ojw28 opened this issue Oct 7, 2016 · 3 comments
Closed

PlaybackControlView leaks itself and anything it refers to (including the player instance) #1908

ojw28 opened this issue Oct 7, 2016 · 3 comments
Labels
bug

Comments

@ojw28
Copy link
Contributor

ojw28 commented Oct 7, 2016

This is demonstrated by the app here:
https://github.com/PerkmannM/Demo-ExoPlayer
@ojw28 ojw28 mentioned this issue Oct 7, 2016
Closed
@ojw28
Copy link
Contributor Author

ojw28 commented Oct 7, 2016

Notes:

  • The leak is much less severe if you upgrade to ExoPlayer r2.0.2 (it's still there though).
  • Until we fix this, you can easily work around the problem, or at least mitigate it, by explicitly clearing the player from the view when it's no longer required, like: mPlaybackControlView.setPlayer(null); (for example on onStop).

@ojw28 ojw28 added the bug label Oct 7, 2016
ojw28 added a commit that referenced this issue Oct 11, 2016
@ojw28
UI component improvements
91f8328 
- Make sure no events are posted on PlaybackControlView
  if it's not attached to a window. This can cause leaks.
  The target hide time is recorded if necessary and
  processed when the view is re-attached.
- Deduplicated PlaybackControlView.VisibilityListener
  invocations.
- Fixed timeouts to be more intuitive (I think).
- Fixed initial visibility of PlaybackControlView when
  used as part of SimpleExoPlayerView.
- Made some more attributes configurable from layout xml.

Issue: #1908
Issue: #1919
Issue: #1923

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135679988
@ojw28 ojw28 closed this as completed Oct 11, 2016
@PerkmannM
Copy link

Thank you for fixing this issue!

When do you plan to release this version?

@philipgiuliani
Copy link

Would be awesome to see a new release soon! :)

@ojw28 ojw28 mentioned this issue Oct 13, 2016
Closed
@google google locked and limited conversation to collaborators Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@philipgiuliani @ojw28 @PerkmannM