Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seeking to end position when paused causes transition to next period #2439

Closed
PaulWoitaschek opened this issue Feb 10, 2017 · 1 comment
Closed

Seeking to end position when paused causes transition to next period #2439

PaulWoitaschek opened this issue Feb 10, 2017 · 1 comment
Assignees
@ojw28
Labels
bug

Comments

@PaulWoitaschek
Copy link

ExoPlayer 2.2.0
Nexus 5x
Android 7.1.1

I use a ConcatenatingMediaSource. When I call seekTo with the current windowIndex and the duration of the file as positionMs in state STATE_PAUSED and playWhenReady=false I receive two events: onPositionDisconunitywith that frame and onPositionDisconitywith 0 but with the windowIndex increased.

This is problematic as when a user seeks with the seekbar he does not want to go to the next track when the player is paused.
@ojw28 ojw28 changed the title SeekTo last positionMs leads to window index incrementing Seeking to end position when paused causes transition to next period Feb 13, 2017
@ojw28 ojw28 added the bug label Feb 13, 2017
ojw28 added a commit that referenced this issue Jan 3, 2018
@ojw28
Force audio renderers to report same position when not started
88abb15 
Whilst the previous behavior was WAI and had the advantage of
updating the position to be more exact when known, there were
a couple of disadvantages:

1. If seeking to the very end of a period in a playlist when
   paused, the position adjustment could trigger a position
   discontinuity to the next period.
2. We de-duplicate seeks to the current playback position.
   The position adjustment can prevent this from being
   effective. This is particularly important with the new
   SeekParameters support. When seeking to nearest sync point
   it's often possible to de-duplicate seeks, but we cannot
   do so if the playback position adjusts away from the sync
   point's time.

Issue: #2439
Issue: #2882

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=180540736
@ojw28
Copy link
Contributor

ojw28 commented Jan 3, 2018

Fixed in dev-v2.

@ojw28 ojw28 closed this as completed Jan 3, 2018
@google google locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ojw28 ojw28

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PaulWoitaschek @ojw28