Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to pass Mp3 / FMP4 / TS extractor flags through DefaultExtractorsFactory #2657

Closed
ojw28 opened this issue Apr 7, 2017 · 1 comment
Closed

Make it possible to pass Mp3 / FMP4 / TS extractor flags through DefaultExtractorsFactory #2657

ojw28 opened this issue Apr 7, 2017 · 1 comment
Labels
enhancement

Comments

@ojw28
Copy link
Contributor

ojw28 commented Apr 7, 2017

As per title.
This was referenced Apr 7, 2017
Closed
Closed
ojw28 added a commit that referenced this issue Apr 19, 2017
@ojw28
Remove reflection + make it easy to set extractor flags
85adecf 
The idea of using reflection was so that a developer could
delete a package they didn't want and have everything else
still compile. However, a developer doing this is likely
building from source, in which case editing the factories
too is pretty trivial.

Removing the reflection makes specifying extractor flags
via the default factory easy, and removes the need for
special proguard config.

Issue: #2657

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=152810423
@ojw28
Copy link
Contributor Author

ojw28 commented Apr 25, 2017

This is supported in dev-v2.

@ojw28 ojw28 closed this as completed Apr 25, 2017
@google google locked and limited conversation to collaborators Aug 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ojw28