Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webvtt subtitles in HLS are not displayed when the PTS wraps around #2928

Closed
bbagland opened this issue Jun 9, 2017 · 4 comments
Closed
Assignees

Comments

@bbagland
Copy link

bbagland commented Jun 9, 2017

Issue description

Play a HLS stream where the PTS from the main video segment are wrapping around with webvtt subtitles.
bugreport.1.txt.gz
The webvtt subtitles are never displayed.

Reproduction steps

It is reproduced with the demo on the latest release 2.4.1.
it is not necessary, but it is easier if subtitles are set by default:

  DefaultTrackSelector.Parameters parameters = trackSelector.getParameters();
  parameters = parameters.withPreferredTextLanguage("heb");
  trackSelector.setParameters(parameters);

Link to test content

stream to be sent by email

Version of ExoPlayer being used

release 2.4.1 (commit 9f81485)

Device(s) and version(s) of Android being used

reproduced on Sony xperia z3 compact, as well as android tv devices.

@bbagland
Copy link
Author

bbagland commented Jun 9, 2017

The subtitles are displayed if we call adjustTsTimestamp instead of adjustTsTimestamp instead of adjustSampleTimestamp in WebvttExtractor.java, ie:

long sampleTimeUs = firstCueTimeUs + timestampAdjuster.adjustTsTimestamp(Long.parseLong(mediaTimestampMatcher.group(1))) - vttTimestampUs;

@AquilesCanta AquilesCanta self-assigned this Jun 9, 2017
@AquilesCanta
Copy link
Contributor

A fix will be available in the next push. Thanks for reporting and your patience!

ojw28 pushed a commit that referenced this issue Sep 19, 2017
Issue:#2928

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=169246424
@ojw28
Copy link
Contributor

ojw28 commented Sep 19, 2017

This is fixed in dev-v2, and will be in r2.5.3, which will be released some time this week.

@ojw28 ojw28 closed this as completed Sep 19, 2017
ojw28 pushed a commit that referenced this issue Sep 19, 2017
Issue:#2928

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=169246424
@bbagland
Copy link
Author

Thanks.
I no longer have access to the environnent to replicate, but I will see if I can check nonetheless.

ojw28 pushed a commit that referenced this issue Sep 20, 2017
Issue:#2928

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=169246424
@google google locked and limited conversation to collaborators Jan 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants