Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PGS and VOBSUB subtitles #3008

Closed
wischnow opened this issue Jun 30, 2017 · 5 comments
Closed

Support PGS and VOBSUB subtitles #3008

wischnow opened this issue Jun 30, 2017 · 5 comments
Assignees

Comments

@wischnow
Copy link
Contributor

Hello,

Issue description

From the documentation and the conversations here I expected PGS and VOBSUB subtitles to work in ExoPlayer, but it seems they are not rendered.

Reproduction steps

Use the ExoPlayer demo app with this sample content from the Kodi repository of samples:

https://drive.google.com/file/d/0BwxFVkl63-lEVEluSFZ4NlhpLUk/view

Link to test content

See above, which is a MKV with PGS.

Unfortunately I don't have a sample with a VOBSUB track that I can share, but those tracks aren't rendered either.

Version of ExoPlayer being used

ExoPlayer version 2.4.2, used via gradle.

Device(s) and version(s) of Android being used

Nexus Player with Android 7.1.2

@ojw28
Copy link
Contributor

ojw28 commented Jun 30, 2017

I don't think we support either at the moment. Marking as an enhancement. We're unlikely to prioritize this, however, so the most likely path to this being supported would be an external contribution.

@ojw28 ojw28 changed the title Matroska file with PGS or VOBSUB not showing the subtitles Support PGS and VOBSUB subtitles Jun 30, 2017
@drhill
Copy link
Contributor

drhill commented Jul 5, 2017

I had submitted code awhile back for PGS that was rejected because I translated the ffmpeg implementation into java.

Afterwards I started an implementation from scratch using other sources as documentation. I implemented it in my video app which can be viewed here:

https://github.com/drhill/homeview/tree/master/app/src/main/java/com/monsterbutt/homeview/player/text/pgs

Anyone who wants to take what I did and integrate it into ExoPlayer is welcome to.

@ojw28
Copy link
Contributor

ojw28 commented Jan 2, 2018

@drhill - If it's just that package (i.e. the three files), and if you could provide a few pieces of test content, then that looks like something we could get merged relatively easily. We'd really need the files sent as a proper pull request from yourself though; it's important that we have a proper attribution trail for all changes we accept. Thanks!

@drhill
Copy link
Contributor

drhill commented Jan 6, 2018

PR: #3673

ojw28 added a commit that referenced this issue Jan 15, 2018
Issue: #3008

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=181455340
@ojw28 ojw28 closed this as completed Jan 23, 2018
@ojw28
Copy link
Contributor

ojw28 commented Jan 23, 2018

PGS is now supported (thanks @drhill!). Assuming VOBSUB is different, I think we'd add support if and only if someone provides a contribution.

@google google locked and limited conversation to collaborators Jun 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants