Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samsung SM-T585 crashes and turns off or restart. #3257

Closed
marcinOz opened this issue Sep 11, 2017 · 23 comments
Closed

Samsung SM-T585 crashes and turns off or restart. #3257

marcinOz opened this issue Sep 11, 2017 · 23 comments

Comments

@marcinOz
Copy link

marcinOz commented Sep 11, 2017

Issue description

Device turns off or restarts after playback of a stream (stream with DRM license provided by mail).
It's probably related to auto quality change because sometimes it could play very long till I enable random adaptation and sometimes it just crashes few seconds after start.

Reproduction steps

  1. Added stream with DRM license to ExoPlayer demo "media.exolist.json" file,
  2. Run the app,
  3. Play stream

Link to test content

stream with DRM license provided by mail

Version of ExoPlayer being used

r2.5.2

Device(s) and version(s) of Android being used

Samsung SM-T585
Android: 7.0
Build number: NRD90M.T585XXU2BQE4

A full bug report captured from the device

In all tests 2 warnings and one error repeats:

09-11 15:10:59.915 8997-9141/com.google.android.exoplayer2.demo W/AHierarchicalStateMachine: Warning message AMessage(what = 'omxI') = {
                   int32_t type = 0
                   int32_t event = 3
                   int32_t data1 = 1
  int32_t data2 = 117440527
                 } unhandled in root state.

...

09-11 15:11:00.740 2432-2462/? E/OMXNodeInstance: setParameter(980003c:Exynos.avc.dec.secure, ParamPortDefinition(0x2000001)) ERROR: BadParameter(0x80001005)

09-11 15:11:00.740 8997-9141/com.google.android.exoplayer2.demo W/ACodec: [OMX.Exynos.avc.dec.secure] setting nBufferCountActual to 27 failed: -2147483648

Full Log (additional two provided by email).

09-11 15:10:56.113 8997-9128/com.google.android.exoplayer2.demo I/System.out: (HTTPLog)-Static: isSBSettingEnabled false
09-11 15:10:56.118 8997-9128/com.google.android.exoplayer2.demo I/System.out: (HTTPLog)-Static: isSBSettingEnabled false
09-11 15:10:56.224 8997-8997/com.google.android.exoplayer2.demo D/EventLogger: sourceInfo [periodCount=1, windowCount=1
09-11 15:10:56.224 8997-8997/com.google.android.exoplayer2.demo D/EventLogger:   period [?]
09-11 15:10:56.225 8997-8997/com.google.android.exoplayer2.demo D/EventLogger:   window [23.99, true, true]
09-11 15:10:56.225 8997-8997/com.google.android.exoplayer2.demo D/EventLogger: ]
09-11 15:10:56.342 2849-2849/? D/WifiTrafficPoller: notifyOnDataActivity() - mBusMaxLock.acquire()
09-11 15:10:57.116 8997-9128/com.google.android.exoplayer2.demo I/System.out: (HTTPLog)-Static: isSBSettingEnabled false
09-11 15:10:57.117 8997-9128/com.google.android.exoplayer2.demo I/System.out: (HTTPLog)-Static: isSBSettingEnabled false
09-11 15:10:57.122 2849-3095/? D/wifi: onLinkStatsResults: radio_stat.on_time = 410441
09-11 15:10:57.123 2849-3095/? D/wifi: onLinkStatsResults: radio_stat.tx_time = 2027
09-11 15:10:57.123 2849-3095/? D/wifi: onLinkStatsResults: radio_stat.rx_time = 5570
09-11 15:10:57.123 2849-3095/? D/wifi: android_net_wifi_getLinkLayerStats: radio_stat.on_time = 410441
09-11 15:10:57.123 2849-3095/? D/wifi: android_net_wifi_getLinkLayerStats: radio_stat.tx_time = 2027
09-11 15:10:57.123 2849-3095/? D/wifi: android_net_wifi_getLinkLayerStats: radio_stat.rx_time = 5570
09-11 15:10:57.131 2849-3095/? D/WifiStateMachine: Current network is: "AndroidOKE" , ID is: 9
09-11 15:10:57.131 2849-3095/? D/WifiStateMachine: Current network is still qualified due to heavy traffic, txSuccessRate=91.66491714144291 rxSuccessRate=0.0
09-11 15:10:57.131 2849-3095/? D/WifiStateMachine: Heavy traffic on current network (txSuccessRate=91.66491714144291 rxSuccessRate=0.0), bail out...
09-11 15:10:57.210 8997-8997/com.google.android.exoplayer2.demo D/EventLogger: sourceInfo [periodCount=1, windowCount=1
09-11 15:10:57.210 8997-8997/com.google.android.exoplayer2.demo D/EventLogger:   period [?]
09-11 15:10:57.210 8997-8997/com.google.android.exoplayer2.demo D/EventLogger:   window [23.98, true, true]
09-11 15:10:57.210 8997-8997/com.google.android.exoplayer2.demo D/EventLogger: ]
09-11 15:10:57.211 8997-9136/com.google.android.exoplayer2.demo I/System.out: (HTTPLog)-Static: isSBSettingEnabled false
09-11 15:10:57.212 8997-9135/com.google.android.exoplayer2.demo I/System.out: (HTTPLog)-Static: isSBSettingEnabled false
09-11 15:10:57.216 8997-9135/com.google.android.exoplayer2.demo I/System.out: (HTTPLog)-Static: isSBSettingEnabled false
09-11 15:10:57.217 8997-9136/com.google.android.exoplayer2.demo I/System.out: (HTTPLog)-Static: isSBSettingEnabled false
09-11 15:10:57.344 2849-2849/? D/WifiTrafficPoller: notifyOnDataActivity() - mBusMaxLock.acquire()
09-11 15:10:57.678 3714-3714/? D/io_stats: !@ 179,0 r 33657 2011770 w 6264 110868 d 775 25432 f 2372 2373 iot 23510 22203 th 51200 0 0 pt 0 inp 0 0 541.372
09-11 15:10:58.346 2849-2849/? D/WifiTrafficPoller: notifyOnDataActivity() - mBusMaxLock.acquire()
09-11 15:10:59.348 2849-2849/? D/WifiTrafficPoller: notifyOnDataActivity() - mBusMaxLock.acquire()
09-11 15:10:59.710 8997-8997/com.google.android.exoplayer2.demo D/EventLogger: videoFormatChanged [22.92, id=p0va0br1800000, mimeType=video/avc, bitrate=1800000, res=704x396, fps=25.0]
09-11 15:10:59.914 2432-9142/? I/EXYNOS_BASE_PORT: [0xec999000][Exynos_OMX_PortDisableProcess] Before disabling output port, do flush
09-11 15:10:59.914 8997-9141/com.google.android.exoplayer2.demo I/ACodec: [OMX.Exynos.avc.dec.secure] Now handling output port settings change
09-11 15:10:59.914 2432-9145/? W/libexynosv4l2: failed to ioctl: VIDIOC_DQBUF (22 - Invalid argument)
09-11 15:10:59.915 8997-9141/com.google.android.exoplayer2.demo W/AHierarchicalStateMachine: Warning message AMessage(what = 'omxI') = {
                                                                                               int32_t type = 0
                                                                                               int32_t event = 3
                                                                                               int32_t data1 = 1
                                                                                               int32_t data2 = 117440527
                                                                                             } unhandled in root state.
09-11 15:10:59.918 2432-9142/? I/EXYNOS_BASE_PORT: [0xec999000][Exynos_OMX_PortDisableProcess] Disable output Port
09-11 15:10:59.999 2849-3029/? D/SamsungAlarmManager: Expired : 8
09-11 15:11:00.000 2849-3029/? I/SamsungAlarmManager: setLocked to kernel - T:3 / 20170911T151143, SetElapsed=587474, nowELAPSED=543696
09-11 15:11:00.000 2849-3029/? V/SamsungAlarmManager: Sending to uid : 1000 action=android.intent.action.TIME_TICK alarm=Alarm{6643291 type 3 when 543696 android}
09-11 15:11:00.002 2849-2849/? D/SamsungAlarmManager: setExact Intent (T:3/F:1/AC:false) 20170911T151200 - CU:1000/CP:2849
09-11 15:11:00.003 3226-3226/? D/KeyguardUpdateMonitor: received broadcast android.intent.action.TIME_TICK
09-11 15:11:00.004 3226-3226/? D/KeyguardUpdateMonitor: handleTimeUpdate#start
09-11 15:11:00.005 2849-2849/? I/ActivityManager: Killing 8839:com.samsung.android.bbc.bbcagent/1000 (adj 906): DHA:empty #25
09-11 15:11:00.016 3226-3226/? D/KeyguardUpdateMonitor: handleTimeUpdate#end
09-11 15:11:00.016 3226-3226/? D/SystemUI_Clock: Clock received ACTION_TIME_TICK : start
09-11 15:11:00.017 3226-3226/? D/SystemUI_Clock: Clock received ACTION_TIME_TICK : end
09-11 15:11:00.023 2849-3100/? D/ActivityManager: cleanUpApplicationRecord -- 8839
09-11 15:11:00.030 3226-3226/? D/TextClock: TextClock received ACTION_TIME_TICK : start
09-11 15:11:00.030 3226-3226/? D/TextClock: TextClock received ACTION_TIME_TICK : end
09-11 15:11:00.032 3226-3226/? D/TextClock: TextClock received ACTION_TIME_TICK : start
09-11 15:11:00.034 3226-3226/? D/TextClock: TextClock received ACTION_TIME_TICK : end
09-11 15:11:00.048 3226-3226/? D/TextClock: TextClock received ACTION_TIME_TICK : start
09-11 15:11:00.049 3226-3226/? D/TextClock: TextClock received ACTION_TIME_TICK : end
09-11 15:11:00.052 3226-3226/? D/SystemUI_DateView: DateView received ACTION_TIME_TICK : start
09-11 15:11:00.053 3226-3226/? D/SystemUI_DateView: DateView received ACTION_TIME_TICK : end
09-11 15:11:00.055 3226-3226/? D/SystemUI_Clock: Clock received ACTION_TIME_TICK : start
09-11 15:11:00.058 3226-3226/? D/SystemUI_Clock: Clock received ACTION_TIME_TICK : end
09-11 15:11:00.065 3226-3226/? D/DateTimeView: DateTimeView received ACTION_TIME_TICK : start
09-11 15:11:00.085 3226-3226/? D/DateTimeView: DateTimeView received ACTION_TIME_TICK : end
09-11 15:11:00.093 3226-3226/? D/TextClock: TextClock received ACTION_TIME_TICK : start
09-11 15:11:00.094 3226-3226/? D/TextClock: TextClock received ACTION_TIME_TICK : end
09-11 15:11:00.094 3226-3226/? D/TextClock: TextClock received ACTION_TIME_TICK : start
09-11 15:11:00.095 3226-3226/? D/TextClock: TextClock received ACTION_TIME_TICK : end
09-11 15:11:00.098 3226-3226/? D/TextClock: TextClock received ACTION_TIME_TICK : start
09-11 15:11:00.099 3226-3226/? D/TextClock: TextClock received ACTION_TIME_TICK : end
09-11 15:11:00.100 3226-3226/? D/TextClock: TextClock received ACTION_TIME_TICK : start
09-11 15:11:00.100 3226-3226/? D/TextClock: TextClock received ACTION_TIME_TICK : end
09-11 15:11:00.135 2849-3095/? D/wifi: onLinkStatsResults: radio_stat.on_time = 413105
09-11 15:11:00.135 2849-3095/? D/wifi: onLinkStatsResults: radio_stat.tx_time = 2039
09-11 15:11:00.135 2849-3095/? D/wifi: onLinkStatsResults: radio_stat.rx_time = 5681
09-11 15:11:00.135 2849-3095/? D/wifi: android_net_wifi_getLinkLayerStats: radio_stat.on_time = 413105
09-11 15:11:00.135 2849-3095/? D/wifi: android_net_wifi_getLinkLayerStats: radio_stat.tx_time = 2039
09-11 15:11:00.135 2849-3095/? D/wifi: android_net_wifi_getLinkLayerStats: radio_stat.rx_time = 5681
09-11 15:11:00.138 2849-3095/? D/WifiStateMachine: Current network is: "AndroidOKE" , ID is: 9
09-11 15:11:00.138 2849-3095/? D/WifiStateMachine: Current network is still qualified due to heavy traffic, txSuccessRate=129.33245857072146 rxSuccessRate=0.0
09-11 15:11:00.139 2849-3095/? D/WifiStateMachine: Heavy traffic on current network (txSuccessRate=129.33245857072146 rxSuccessRate=0.0), bail out...
09-11 15:11:00.248 8997-9128/com.google.android.exoplayer2.demo I/System.out: (HTTPLog)-Static: isSBSettingEnabled false
09-11 15:11:00.248 8997-9128/com.google.android.exoplayer2.demo I/System.out: (HTTPLog)-Static: isSBSettingEnabled false
09-11 15:11:00.349 2849-2849/? D/WifiTrafficPoller: notifyOnDataActivity() - mBusMaxLock.acquire()
09-11 15:11:00.739 2432-9142/? I/EXYNOS_BASE_PORT: [0xec999000][Exynos_OMX_PortEnableProcess] Enable output Port
09-11 15:11:00.740 8997-9141/com.google.android.exoplayer2.demo D/SurfaceUtils: set up nativeWindow 0xeeee0808 for 704x400, color 0x123, rotation 0, usage 0x6900
09-11 15:11:00.740 2432-2462/? E/OMXNodeInstance: setParameter(980003c:Exynos.avc.dec.secure, ParamPortDefinition(0x2000001)) ERROR: BadParameter(0x80001005)
09-11 15:11:00.740 8997-9141/com.google.android.exoplayer2.demo W/ACodec: [OMX.Exynos.avc.dec.secure] setting nBufferCountActual to 27 failed: -2147483648
09-11 15:11:00.741 8997-9141/com.google.android.exoplayer2.demo I/ACodec: [OMX.Exynos.avc.dec.secure] configureOutputBuffersFromNativeWindow setBufferCount : 26, minUndequeuedBuffers : 3
09-11 15:11:00.756 8997-9141/com.google.android.exoplayer2.demo I/ACodec: [OMX.Exynos.avc.dec.secure] Now Executing
09-11 15:11:01.351 2849-2849/? D/WifiTrafficPoller: notifyOnDataActivity() - mBusMaxLock.acquire()
09-11 15:11:01.400 2849-3020/? D/SensorService: [SO] 8.742 0.049 3.779
09-11 15:11:01.576 2423-2504/? I/AudioFlinger: BUFFER TIMEOUT: remove(4096) from active list on thread 0xee3831c0
09-11 15:11:01.576 2423-2504/? I/SoundBoosterEffectPlus: SB_reset SoundBooster sessionId(-3)
09-11 15:11:01.576 2423-2504/? I/SoundBooster7: BuffClear()
09-11 15:11:01.591 2423-2475/? I/APM_AudioPolicyManager: stopOutput() output 13, stream 3, session 129
09-11 15:11:02.353 2849-2849/? D/WifiTrafficPoller: notifyOnDataActivity() - mBusMaxLock.acquire()
09-11 15:11:02.682 3714-3714/? D/io_stats: !@ 179,0 r 33657 2011770 w 6282 111720 d 776 25436 f 2373 2374 iot 23520 22222 th 51200 0 0 pt 0 inp 0 0 546.378
09-11 15:11:03.127 2849-2859/? D/BatteryService: !@BatteryListener : batteryPropertiesChanged!
09-11 15:11:03.127 2849-2859/? D/BatteryService: level:86, scale:100, status:2, health:2, present:true, voltage: 4046, temperature: 301, technology: Li-ion, AC powered:false, USB powered:true, POGO powered:false, Wireless powered:false, icon:17303702, invalid charger:0, maxChargingCurrent:0, maxChargingVoltage:0, chargeCounter:0
09-11 15:11:03.127 2849-2859/? D/BatteryService: online:4, current avg:-334, charge type:2, power sharing:false, high voltage charger:false, capacity:280000, batterySWSelfDischarging:false, misc_event:0, current_event:0, current_now:-335
09-11 15:11:03.127 2849-2849/? D/BatteryService: Sending ACTION_BATTERY_CHANGED.
09-11 15:11:03.129 3226-3226/? D/KeyguardUpdateMonitor: received broadcast android.intent.action.BATTERY_CHANGED
09-11 15:11:03.129 3226-3226/? D/KeyguardUpdateMonitor: handleBatteryUpdate
09-11 15:11:03.131 2849-2849/? D/SamsungPhoneWindowManager: ACTION_BATTERY_CHANGED - Level :: 86, battStatus :: 2
09-11 15:11:03.131 2849-2849/? V/UiModeManager: updateLocked: null action, mDockState=0, category=null
09-11 15:11:03.132 2849-2849/? D/UiModeManager: updateConfigurationLocked: mDockState=0; mCarMode=false; mNightMode=1; uiMode=17
09-11 15:11:03.132 2849-2849/? D/GameManagerService: new battery level: 86
09-11 15:11:03.132 3226-3226/? D/PowerUI: showing power sharing dialogfalse
09-11 15:11:03.132 3226-3226/? D/PowerUI: priorPlugType = 2 mPlugType =  2
09-11 15:11:03.132 3226-3226/? D/PowerUI.Notification: showChargingNotice oldChargingType : 5 currentChargingType : 5 oldChargingTime : 0 mChargingTime : 0
09-11 15:11:03.132 3226-3226/? D/PowerUI.Notification: Slow charger noti is already shown, so return!
09-11 15:11:03.133 3226-3226/? D/BatteryMeterDrawable: isSomethingChanged - false
09-11 15:11:03.134 3226-3226/? D/BatteryMeterDrawable: isSomethingChanged - false
09-11 15:11:03.134 3226-3226/? D/BatteryController: onReceive - ACTION_BATTERY_CHANGED : mLevel = 86
09-11 15:11:03.141 2849-3095/? D/wifi: onLinkStatsResults: radio_stat.on_time = 415867
09-11 15:11:03.141 2849-3095/? D/wifi: onLinkStatsResults: radio_stat.tx_time = 2052
09-11 15:11:03.141 2849-3095/? D/wifi: onLinkStatsResults: radio_stat.rx_time = 5749
09-11 15:11:03.141 2849-3095/? D/wifi: android_net_wifi_getLinkLayerStats: radio_stat.on_time = 415867
09-11 15:11:03.141 2849-3095/? D/wifi: android_net_wifi_getLinkLayerStats: radio_stat.tx_time = 2052
09-11 15:11:03.141 2849-3095/? D/wifi: android_net_wifi_getLinkLayerStats: radio_stat.rx_time = 5749
09-11 15:11:03.145 2849-3095/? D/WifiStateMachine: Current network is: "AndroidOKE" , ID is: 9
09-11 15:11:03.145 2849-3095/? D/WifiStateMachine: Current network is still qualified due to heavy traffic, txSuccessRate=105.66622928536073 rxSuccessRate=0.0
09-11 15:11:03.145 2849-3095/? D/WifiStateMachine: Heavy traffic on current network (txSuccessRate=105.66622928536073 rxSuccessRate=0.0), bail out...
09-11 15:11:03.354 2849-2849/? D/WifiTrafficPoller: notifyOnDataActivity() - mBusMaxLock.acquire()
09-11 15:11:04.101 2423-2504/? I/audio_hw_primary: do_out_standby +
09-11 15:11:04.106 2423-2504/? D/audio_hw_primary: output_devices devices:0
09-11 15:11:04.106 2423-2504/? D/audio_hw_primary: output_devices devices:0
09-11 15:11:04.106 2423-2504/? V/audio_hw_primary: select_devices output_scenario:-1 input_scenario:-1 out_snd_device 0x0 in_snd_device:0x0
09-11 15:11:04.106 2423-2504/? I/audio_route: > audio_route_reset :
09-11 15:11:04.106 2423-2504/? I/audio_route: > audio_route_update_mixer : +
09-11 15:11:04.109 2423-2504/? I/audio_route: > audio_route_update_mixer : changed(13) -
09-11 15:11:04.109 2423-2504/? I/audio_hw_primary: select_devices - 
09-11 15:11:04.109 2423-2504/? I/audio_hw_primary: do_out_standby -
09-11 15:11:04.333 2849-4455/? D/SSRM:m: SIOP:: AP = 350, PST = 351 (W:30), LCD = 180
09-11 15:11:04.355 2849-2849/? D/WifiTrafficPoller: notifyOnDataActivity() - mBusMaxLock.acquire()
01-01 00:00:00.000 0-0/? E/Internal: device '520364b5e861730f' not found
@m-scheepers
Copy link

As this issue is considered to be device specific, would there be a way to address this to Samsung? On our side we do not appear to have direct access to any support channel.

I have requested our customer to indicate if more devices appear to be impacted with this issue.

@m-scheepers
Copy link

We have received an update from our customer:

Our Devices Team confirmed us that all Samsung tablets with 7.0 version have this issue.
it seems that everybody knows the problem . The issue has been solved on phone devices but on tablet is taking longer. Samsung is aware of this.
You could push to Samsung for the new firmware to solve the issue.

Is there any way to highlight this issue to Samsung via Exoplayer team? Afterwards this does not appear to require a fix on Exoplayer side.

@ojw28
Copy link
Contributor

ojw28 commented Sep 18, 2017

all Samsung tablets with 7.0

Please can you provide a list of tablets actually tested and confirmed to have the issue? Thanks.

@ojw28
Copy link
Contributor

ojw28 commented Sep 19, 2017

Please could you also provide some kind of reference to the issue Samsung is aware of? I think we have a candidate workaround at the application layer, but without knowing what that issue was or a list of affected devices, it's pretty hard for us to validate that we're doing the right thing. Thanks.

@ojw28
Copy link
Contributor

ojw28 commented Sep 19, 2017

d346266 should work around this issue on SM-T585. Expanding the workaround to more devices is pending receipt of more information, as requested above. Thanks.

@m-scheepers
Copy link

Thanks for the effort for a possible workaround.

I have again requested our customer an update with regards to tested devices on their side. I hope to provide an update soon.

We have retested this on our side again with the device which was shipped to us. The issue does not appear to occur for all streams which are used in the app (originating from multiple streaming platforms).

@m-scheepers
Copy link

Our customer plans to provide feedback about impacted devices by the end of this week. Once available I will forward these.

@nicolassabin35
Copy link

Hi Mark86NL,

Any update?

@fragmentic
Copy link

The same problem reproduced on Samsung Galaxy J1 (Android 5.1.1)
Used exoplayer version: r2.5.3.

When you plan to include this workaround?

@m-scheepers
Copy link

@nicolassabin35 I have received response from our customer who performed some tests in combination with Samsung locally. The SM-T585 - Tab A is the only device where the issue was reproduced.

@ojw28
Copy link
Contributor

ojw28 commented Oct 2, 2017

As above, d346266 should fix the issue for the SM-T585.

@fragmentic - How did you validate that the issue you're seeing is the same? Please can you try modifying codecAdaptationWorkaroundMode to return ADAPTATION_WORKAROUND_MODE_ALWAYS for the affected device (see the change ref'd above; it should be fairly self explanatory what needs to be done). If that works around the issue, please feel free to send us a pull request and we'll get it merged. Thanks!

@ojw28 ojw28 closed this as completed Oct 2, 2017
@m-scheepers
Copy link

@ojw28 our customer also identified another device SM-A520F (Samsung Galaxy A5 2017) which has this issue on Android 7.0. How would you suggest to proceed with this? Can this be added as a device specific workaround?

@ojw28 ojw28 reopened this Oct 4, 2017
@m-scheepers
Copy link

@ojw28 I have noticed this issue was reopened. Would there any feedback required from our side in order to add above mentioned device for this fix? Or was this reopened for another reason?

We are currently planning some updates for our Android apps and would like to see if we could include these fixes there

@ojw28
Copy link
Contributor

ojw28 commented Oct 10, 2017

Is the customer able to confirm that the same fix works for the SM-A520F as well? You could verify this by providing them with a build of the app in which codecAdaptationWorkaroundMode is modified to return ADAPTATION_WORKAROUND_MODE_ALWAYS on this device, as it now does for the SM-T585. The method can be found here.

I'm hesitant to enable the workaround for the additional device without someone validating that it resolves the issue, because it's easy to conflate multiple issues of this type together (i.e. assume they're the same when in fact they're different). If this can be validated, we'll merge a change. Or better, please send us a pull request. Else we will have to get hold of one of these devices to validate on our side, however this may take some time.

Thanks!

@marcinOz
Copy link
Author

Tested on SM-T585 and can confirm it is fixed for that device.

@ojw28
Copy link
Contributor

ojw28 commented Oct 16, 2017

We need confirmation for the SM-A520F for it to be added to the workaround list.

@m-scheepers
Copy link

Also received feedback for SM-A520F that the same workaround worked there based on the test app we provided.

ojw28 added a commit that referenced this issue Oct 19, 2017
Issue: #3355
Issue: #3257

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=172587141
ojw28 added a commit that referenced this issue Oct 19, 2017
Issue: #3355
Issue: #3257

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=172587141
@ojw28 ojw28 closed this as completed Oct 20, 2017
@noamtamim
Copy link
Contributor

noamtamim commented Nov 6, 2017

@ojw28 a customer has reported this exact issue on two other Samsung devices:

  • Another variant of A5 (SM-A510FD)
  • J7 (SM-J700F)

We don't have those devices in our possession, but if a workaround is possible we can forward the version to the customer.

@ojw28
Copy link
Contributor

ojw28 commented Nov 6, 2017

  • The workaround should already be applied to the SM-A510FD as of r2.5.4, since the check we added was startsWith("SM-A520"). So if you've picked up that version in your app, I'd expect the issue to be resolved for them.
  • I guess we'll add J7 to the list as well :(.

@noamtamim
Copy link
Contributor

@ojw28 the model (in Build.MODEL) is SM-A510F, not SM-A520. Your check does not apply. Maybe it should be startsWith("SM-A5") (as well as "SM-J7").

Do you have any insights about why this happens?

@ojw28
Copy link
Contributor

ojw28 commented Nov 6, 2017

Ah. I think SM-A5 might be overly broad (and may also include yet-to-be-released devices). I'll add SM-510 explicitly for now.

@noamtamim
Copy link
Contributor

What is the reason for this issue, and why does the workaround work?

@ojw28
Copy link
Contributor

ojw28 commented Nov 6, 2017

Something goes wrong in the decoder when adaptation occurs. I don't have access to the decoder implementation, so it's impossible to say exactly what's broken. Queuing the blank frame likely forces the decoder to better reset its internal state.

ojw28 added a commit that referenced this issue Nov 7, 2017
Issue: #3257

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=174686747
ojw28 added a commit that referenced this issue Nov 13, 2017
Issue: #3257

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=174686747
@google google locked and limited conversation to collaborators Mar 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants