Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End Ad not playing #3715

Closed
VMAXSDK opened this issue Jan 16, 2018 · 0 comments
Closed

End Ad not playing #3715

VMAXSDK opened this issue Jan 16, 2018 · 0 comments
Assignees
@andrewlewis
Labels
bug

Comments

@VMAXSDK
Copy link

VMAXSDK commented Jan 16, 2018

Issue description

Ad with timeoffset as “end” is not playing when AdBreaks with just timeoffset “start” and “end” are present.

Reproduction steps

  1. Download sample app https://github.com/google/ExoPlayer/tree/release-v2/demos/main
  2. Change “ad_tag_url” to https://img.vserv.mobi/vast/ima/sample1.xml
  3. Load the ad and AdBreak having timeOffset=”end” won’t play

Link to test content

https://img.vserv.mobi/vast/ima/sample1.xml

Version of ExoPlayer being used

2.6.1
'com.google.ads.interactivemedia.v3:interactivemedia:3.7.4'

Device(s) and version(s) of Android being used

LG Nexus 5 (Android version 6.0.1)
@andrewlewis andrewlewis self-assigned this Jan 16, 2018
ojw28 pushed a commit that referenced this issue Feb 16, 2018
@andrewlewis
Fix handling of ad tags with only preroll and postroll ads
da08b65 
Content progress is only polled if there are midroll ad groups. If the ad tag
had only preroll/postroll ads, the pending content position was not provided to
IMA, which meant that the postroll ad could never play.

Only set the pending content position if there are midroll ads.

Issue: #3715

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=185680803
@ojw28 ojw28 closed this as completed Feb 16, 2018
ojw28 pushed a commit that referenced this issue Feb 20, 2018
@andrewlewis @ojw28
Fix handling of ad tags with only preroll and postroll ads
95f298f 
Content progress is only polled if there are midroll ad groups. If the ad tag
had only preroll/postroll ads, the pending content position was not provided to
IMA, which meant that the postroll ad could never play.

Only set the pending content position if there are midroll ads.

Issue: #3715

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=185680803
@google google locked and limited conversation to collaborators Jun 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@andrewlewis andrewlewis

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrewlewis @ojw28 @VMAXSDK