Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Crash #3716

Closed
VMAXSDK opened this issue Jan 16, 2018 · 0 comments
Closed

App Crash #3716

VMAXSDK opened this issue Jan 16, 2018 · 0 comments
Assignees
@andrewlewis
Labels
bug

Comments

@VMAXSDK
Copy link

VMAXSDK commented Jan 16, 2018

Issue description

App is crashing with unordered sequencing of timeOffset for AdBreaks

Reproduction steps

  1. Download sample app from https://github.com/google/ExoPlayer/tree/release-v2/demos/main
  2. Change “ad_tag_url” to https://img.vserv.mobi/vast/ima/sample2.xml
  3. Load the ad and it will cause immediate crash.

Link to test content

https://img.vserv.mobi/vast/ima/sample2.xml

Version of ExoPlayer being used

2.6.1
'com.google.ads.interactivemedia.v3:interactivemedia:3.7.4'

Device(s) and version(s) of Android being used

LG Nexus 5 (Android version 6.0.1)

A full bug report captured from the device

E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.google.android.exoplayer2.imademo, PID: 24403
java.lang.ArrayIndexOutOfBoundsException: length=3; index=-1
at com.google.android.exoplayer2.source.ads.AdPlaybackState.setAdCount(AdPlaybackState.java:111)
at com.google.android.exoplayer2.ext.ima.ImaAdsLoader.onAdEvent(ImaAdsLoader.java:481)
at com.google.obf.gy.a(IMASDK:57)
at com.google.obf.gy.a(IMASDK:53)
at com.google.obf.gy.a(IMASDK:90)
at com.google.obf.gq.a(IMASDK:60)
at com.google.obf.hj.f(IMASDK:163)
at com.google.obf.hj.a(IMASDK:41)
at com.google.obf.hk.b(IMASDK:39)
at com.google.obf.hk$1.shouldOverrideUrlLoading(IMASDK:4)
at com.android.webview.chromium.WebViewContentsClientAdapter.shouldOverrideUrlLoading(WebViewContentsClientAdapter.java:74)
at org.chromium.android_webview.AwContentsClient.shouldIgnoreNavigation(AwContentsClient.java:15)
at org.chromium.android_webview.AwContentsClientBridge.shouldOverrideUrlLoading(AwContentsClientBridge.java:140)
at org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method)
at org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:7)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:5417)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
@andrewlewis andrewlewis self-assigned this Jan 16, 2018
@andrewlewis andrewlewis mentioned this issue Feb 12, 2018
Closed
ojw28 pushed a commit that referenced this issue Feb 16, 2018
@andrewlewis
Fix handling of ad tags where ad groups are out of order
4cb2d25 
IMA's cue points may not be in order, so sort them. It looks like IMA events use
time ordered ad indices, so it is not necessary to map between the original cue
point order and the time order.

Issue: #3716

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=185495798
@ojw28 ojw28 closed this as completed Feb 16, 2018
ojw28 pushed a commit that referenced this issue Feb 20, 2018
@andrewlewis @ojw28
Fix handling of ad tags where ad groups are out of order
4fec242 
IMA's cue points may not be in order, so sort them. It looks like IMA events use
time ordered ad indices, so it is not necessary to map between the original cue
point order and the time order.

Issue: #3716

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=185495798
@google google locked and limited conversation to collaborators Jun 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@andrewlewis andrewlewis

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrewlewis @ojw28 @VMAXSDK