Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StringIndexOutOfBoundsException #3792

Closed
axet opened this issue Feb 3, 2018 · 4 comments
Closed

StringIndexOutOfBoundsException #3792

axet opened this issue Feb 3, 2018 · 4 comments
Assignees
@AquilesCanta

Comments

@axet
Copy link

axet commented Feb 3, 2018

#2309

seems like regression with exoplayer:r2.5.4

02-03 21:46:28.536 2741-20507/com.github.axet.torrentclient E/LoadTask: Unexpected exception loading stream
                                                                        java.lang.StringIndexOutOfBoundsException: length=108; regionStart=110; regionLength=-2
                                                                            at java.lang.StringFactory.newStringFromBytes(StringFactory.java:69)
                                                                            at java.lang.StringFactory.newStringFromBytes(StringFactory.java:59)
                                                                            at com.google.android.exoplayer2.metadata.id3.Id3Decoder.decodeGeobFrame(Id3Decoder.java:510)
                                                                            at com.google.android.exoplayer2.metadata.id3.Id3Decoder.decodeFrame(Id3Decoder.java:361)
                                                                            at com.google.android.exoplayer2.metadata.id3.Id3Decoder.decode(Id3Decoder.java:135)
                                                                            at com.google.android.exoplayer2.extractor.mp3.Mp3Extractor.peekId3Data(Mp3Extractor.java:330)
                                                                            at com.google.android.exoplayer2.extractor.mp3.Mp3Extractor.synchronize(Mp3Extractor.java:248)
                                                                            at com.google.android.exoplayer2.extractor.mp3.Mp3Extractor.sniff(Mp3Extractor.java:149)
                                                                            at com.google.android.exoplayer2.source.ExtractorMediaPeriod$ExtractorHolder.selectExtractor(ExtractorMediaPeriod.java:762)
                                                                            at com.google.android.exoplayer2.source.ExtractorMediaPeriod$ExtractingLoadable.load(ExtractorMediaPeriod.java:697)
                                                                            at com.google.android.exoplayer2.upstream.Loader$LoadTask.run(Loader.java:315)
                                                                            at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
                                                                            at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
                                                                            at java.lang.Thread.run(Thread.java:761)
@AquilesCanta
Copy link
Contributor

Can you send a link/media sample to dev.exoplayer@gmail.com?

@axet
Copy link
Author

axet commented Feb 5, 2018

done

@AquilesCanta AquilesCanta self-assigned this Feb 6, 2018
@AquilesCanta
Copy link
Contributor

Could you point us to the last ExoPlayer version on which you know this issue did not occur?

@axet
Copy link
Author

axet commented Feb 12, 2018 •
edited

Nope. It seems #2309 only fixes for decodeCommentFrame, but left unchanged same code in decodeGeobFrame

It is not a regression recent 2.6.1 also fails.

Caused by: java.lang.StringIndexOutOfBoundsException: length=24; regionStart=26; regionLength=-2
   at java.lang.StringFactory.newStringFromBytes(StringFactory.java:69)
   at java.lang.StringFactory.newStringFromBytes(StringFactory.java:59)
   at com.google.android.exoplayer2.metadata.id3.Id3Decoder.decodeGeobFrame(Id3Decoder.java:510)
   at com.google.android.exoplayer2.metadata.id3.Id3Decoder.decodeFrame(Id3Decoder.java:361)
   at com.google.android.exoplayer2.metadata.id3.Id3Decoder.decode(Id3Decoder.java:135)
   at com.google.android.exoplayer2.extractor.mp3.Mp3Extractor.peekId3Data(Mp3Extractor.java:327)
   at com.google.android.exoplayer2.extractor.mp3.Mp3Extractor.synchronize(Mp3Extractor.java:245)
   at com.google.android.exoplayer2.extractor.mp3.Mp3Extractor.sniff(Mp3Extractor.java:144)
   at com.google.android.exoplayer2.source.ExtractorMediaPeriod$ExtractorHolder.selectExtractor(ExtractorMediaPeriod.java:808)
   at com.google.android.exoplayer2.source.ExtractorMediaPeriod$ExtractingLoadable.load(ExtractorMediaPeriod.java:742)
   at com.google.android.exoplayer2.upstream.Loader$LoadTask.run(Loader.java:315)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133) 
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607) 
   at java.lang.Thread.run(Thread.java:761) 

ojw28 pushed a commit that referenced this issue Feb 16, 2018
@AquilesCanta
Make ID3 GEOB frames parsing more robust
4d26b31 
Issue:#3792

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=185668919
@ojw28 ojw28 closed this as completed Feb 16, 2018
ojw28 pushed a commit that referenced this issue Feb 20, 2018
@AquilesCanta @ojw28
Make ID3 GEOB frames parsing more robust
ed52743 
Issue:#3792

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=185668919
@google google locked and limited conversation to collaborators Jun 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AquilesCanta AquilesCanta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@axet @ojw28 @AquilesCanta