Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitle of a dash stream not shown properly #4083

Closed
griygagns opened this issue Apr 4, 2018 · 3 comments
Closed

Subtitle of a dash stream not shown properly #4083

griygagns opened this issue Apr 4, 2018 · 3 comments

Comments

@griygagns
Copy link

Issue description

I have a live dash stream with multiple subtitle tracks. While they can be correctly recognized as TTML, nothing is shown during playback. Also, it is worth noting that shaka player is able to display them properly.

I wonder if it is a bug of exoplayer or something else currently not supported by exoplayer.

Reproduction steps

Sent to dev.exoplayer@gmail.com

Link to test content

Sent to dev.exoplayer@gmail.com

Version of ExoPlayer being used

dev-v2-r.2.7.3

Device(s) and version(s) of Android being used

NA

A full bug report captured from the device

NA

@ojw28
Copy link
Contributor

ojw28 commented Apr 4, 2018

It appears that track_ID is set incorrectly in the subtitle track initialization segments. The track_ID in moov -> trak -> tkhd (in the initialization segments) and moof -> traf -> tfhd (in the media segments) should match, however are 0 and 1 respectively.

Note also that 0 is an invalid value. As per 14496-12:

track_ID is an integer that uniquely identifies this track over the entire life-time of this presentation. Track IDs are never re-used and cannot be zero.

So I think your packager is probably forgetting to set track_ID to 1 when it generates the initialization segments?

It's likely some other DASH players ignore track_ID when extracting FMP4, since you'd only expect 1 track per stream for DASH playbacks. In this case playback will succeed. ExoPlayer doesn't do this because we also support multiple track FMP4 playback (not in the context of DASH), for which track ids are obviously important.

The correct fix for this is to fix the content. Please let me know if you disagree with this analysis. Thanks!

@griygagns
Copy link
Author

Thank you for your detailed analysis. I wrongly guessed that it may be a problem of exoplayer, when I found that shaka player works fine with those subtitle tracks. Anyway, it would be better to close this issue,
which seems to be not related to exoplayer. Thanks again.

ojw28 pushed a commit that referenced this issue Jul 6, 2018
If there is only one track, we can assume that both boxes refer to the same track
even if the track indices don't match.

Issue:#4083

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=203485872
@tonihei
Copy link
Collaborator

tonihei commented Jul 9, 2018

Just to let you know: We pushed a workaround for this issue to ignore the track ids if there is only one track.

ojw28 pushed a commit that referenced this issue Jul 23, 2018
If there is only one track, we can assume that both boxes refer to the same track
even if the track indices don't match.

Issue:#4083

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=203485872
@google google locked and limited conversation to collaborators Aug 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants