Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultLoadControl.Builder should allow to set backBufferDurationUs and retainBackBufferFromKeyframe #4857

Closed
AlienAsRoger opened this issue Sep 23, 2018 · 0 comments
Closed

DefaultLoadControl.Builder should allow to set backBufferDurationUs and retainBackBufferFromKeyframe #4857

AlienAsRoger opened this issue Sep 23, 2018 · 0 comments
Assignees
@ojw28
Labels
enhancement

Comments

@AlienAsRoger
Copy link

Issue description

DefaultLoadControl.Builder is final and public constructors are deprecated for DefaultLoadControl which forces to create a whole copy of DefaultLoadControl just to set backBufferDurationUs and retainBackBufferFromKeyframe

DefaultLoadControl.Builder

DefaultLoadControl

Version of ExoPlayer being used

2.8.4
@AlienAsRoger AlienAsRoger changed the title DefaultLoadControl.Builder should allow to set backBufferDurationUs and retainBackBufferFromKeyframe DefaultLoadControl.Builder should allow to set *backBufferDurationUs* and retainBackBufferFromKeyframe Sep 23, 2018
@AlienAsRoger AlienAsRoger changed the title DefaultLoadControl.Builder should allow to set *backBufferDurationUs* and retainBackBufferFromKeyframe DefaultLoadControl.Builder should allow to set backBufferDurationUs and retainBackBufferFromKeyframe Sep 23, 2018
@ojw28 ojw28 self-assigned this Sep 23, 2018
ojw28 added a commit that referenced this issue Sep 24, 2018
@ojw28
Allow configuration of DefaultLoadControl back buffer
34c3759 
Issue: #4857

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=214254231
@ojw28 ojw28 closed this as completed Sep 24, 2018
ojw28 added a commit that referenced this issue Sep 24, 2018
@ojw28
Allow configuration of DefaultLoadControl back buffer
b0cd6cf 
Issue: #4857

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=214254231
@google google locked and limited conversation to collaborators Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ojw28 ojw28

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlienAsRoger @ojw28