Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimelineQueueNavigator.getSupportedQueueNavigatorActions() ignores shuffle #5065

Closed
kkuepper opened this issue Nov 6, 2018 · 1 comment
Closed

TimelineQueueNavigator.getSupportedQueueNavigatorActions() ignores shuffle #5065

kkuepper opened this issue Nov 6, 2018 · 1 comment
Assignees
@ojw28
Labels
bug

Comments

@kkuepper
Copy link

kkuepper commented Nov 6, 2018

Currently getSupportedQueueNavigatorActions() does not take into account if shuffle is enabled or not. That leads to that ActionSkipToNext or ActionSkipToPrevious is disabled in wrong situations.

Reproduction steps

  • play a list of tracks
  • enable shuffle
  • skip to next track until you hit the latest item the list
    -> ActionSkipToNext is disabled even though not all songs have been shuffled through
@ojw28 ojw28 self-assigned this Nov 6, 2018
@ojw28 ojw28 added the bug label Nov 6, 2018
ojw28 added a commit that referenced this issue Nov 7, 2018
@ojw28
Make TimelineQueueNavigator shuffle aware
15dda17 
Issue: #5065

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=220468285
ojw28 added a commit that referenced this issue Nov 7, 2018
@ojw28
Make TimelineQueueNavigator shuffle aware
fd98d70 
Issue: #5065

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=220468285
@ojw28 ojw28 closed this as completed Nov 7, 2018
@ojw28
Copy link
Contributor

ojw28 commented Nov 7, 2018

This will be fixed in 2.9.1.

@google google locked and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ojw28 ojw28

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kkuepper @ojw28