Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal runtime error #6

Closed
4ntoine opened this issue Jul 4, 2014 · 1 comment
Closed

Internal runtime error #6

4ntoine opened this issue Jul 4, 2014 · 1 comment

Comments

@4ntoine
Copy link

4ntoine commented Jul 4, 2014

http://stackoverflow.com/questions/24554435/exoplayer-playback-error

@4ntoine 4ntoine changed the title Playback failed Internal runtime error Jul 4, 2014
@ojw28
Copy link
Contributor

ojw28 commented Jul 9, 2014

Duplicate of #2 (see stackoverflow thread for details).

@ojw28 ojw28 closed this as completed Jul 9, 2014
b95505017 pushed a commit to b95505017/ExoPlayer that referenced this issue Dec 14, 2015
ojw28 added a commit that referenced this issue Jun 15, 2016
This is a mechanical change. The two new SampleSource classes
are forked from MultiSampleSource, with the logic that previously
was in the demo app's SourceBuilder methods copied into the
corresponding constructors. Subsequent steps will:

1. Pull the initial manifest processing from DashChunkSource and
SmoothStreamingChunkSource into the new SampleSource classes.
2. Remove the construction of ChunkSampleSource instances from
the constructors, instead instantiating children only as needed
when tracks are enabled.
3. Simplify ChunkSampleSource down into a ChunkTrackStream object.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=121001021
ojw28 added a commit that referenced this issue Jun 15, 2016
This change pulls manifest refresh responsibility up to the
top level Dash/SS SampleSource implementations. In following
steps more of the manifest processing logic will be pulled
up (e.g. extracting track groups from the initial manifest),
which will allow ChunkSampleSource/ChunkSource instances to
be further simplified and created on demand.

I've avoided moving/renaming anything for now, so as to keep
it fairly easy to review.

Note that this change does the TODO related to releasing the
manifest fetchers.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=121001139
ojw28 added a commit that referenced this issue Jun 15, 2016
Parse the duration of the media directly from the manifest
in the DASH/SS SampleSource implementations.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=121001296
ojw28 added a commit that referenced this issue Jun 15, 2016
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=121001478
ojw28 added a commit that referenced this issue Jun 15, 2016
Dash/SS SampleSources now instantiate ChunkSource and
ChunkSampleSource (renamed to ChunkTrackStream) instances
on demand as tracks are enabled. The TrackGroups exposed
by the DASH/SS SampleSources are now constructed at the
top level.

Note that this change resolves the TODOs at the top of the
ChunkSource classes, allowing multiple adaptation sets of
the same type.

Next steps will include:

- Bring back UTC timing element support for DASH, which
  will be an extra request during preparation in  the DASH
  SampleSource.
- Simplification of manifest fetching to use a Loader directly
  in the two top level SampleSource classes. ManifestFetcher
  should eventually go away once HLS no longer needs it.
- Eventually, some consolidation between DASH/SS. There's a
  lot of common code there now.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=121001777
ojw28 added a commit that referenced this issue Jun 15, 2016
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=121002218
ojw28 added a commit that referenced this issue Jun 15, 2016
Mechanical step to create a new HlsSource in the library.
Note that naming is now confusing. This will be fixed in
the next CL, when:

HlsSource -> HlsSampleSource
HlsSampleSource+HlsOutput -> HlsOutput
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=122054800
ojw28 added a commit that referenced this issue Jun 15, 2016
1. Merge HlsOutput and HlsSampleSource -> HlsTrackStreamWrapper.
2. Rename HlsSource -> HlsSampleSource2. This will be renamed to
   HlsSampleSource in a subsequent CL.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=122415970
ojw28 added a commit that referenced this issue Jun 15, 2016
Rename HlsSampleSource2 -> HlsSampleSource.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=122418334
ojw28 added a commit that referenced this issue Jun 15, 2016
- Pull loading of the initial manifest up to HlsSampleSource.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=123305312
ojw28 added a commit that referenced this issue Jun 15, 2016
Pull more logic up to HlsSampleSource. Somewhat regretfully,
this also backs out the optimization work done toward the
ref'd issue. I think that's one for another time perhaps...

Issue: #551
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=123417413
ojw28 pushed a commit that referenced this issue Jul 8, 2016
@google google locked and limited conversation to collaborators Jun 28, 2017
yuliskov added a commit to yuliskov/ExoPlayer that referenced this issue Feb 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants