Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix callback for nested signIn or addScopes #29

Merged

Conversation

AntonKozlovskyi
Copy link
Contributor

@AntonKozlovskyi AntonKozlovskyi commented Jul 19, 2021

Fixes #24

@google-cla
Copy link

google-cla bot commented Jul 19, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@AntonKozlovskyi
Copy link
Contributor Author

@googlebot I signed it!

Copy link
Contributor

@petea petea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Anton! Could you also apply this fix to the two other locations in GIDSignIn.m where we set "_currentOptions = nil" after executing the callback block?

GoogleSignIn/Sources/GIDSignIn.m Outdated Show resolved Hide resolved
@AntonKozlovskyi
Copy link
Contributor Author

done

@petea petea changed the title fix calling callback on addScopes Fix callback for nested signIn or addScopes Jul 19, 2021
@petea petea merged commit e6d17e9 into google:main Jul 19, 2021
@petea petea added this to the 6.0.1 milestone Jul 21, 2021
Copy link

@tgun1370 tgun1370 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AntonKozlovskyi:Fix_missing_completion_handler_on_add_scopes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addScopes callback not called when nested
3 participants