Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing the persistent store library in github workflows now fails #320

Closed
jmichelp opened this issue Jun 9, 2021 · 4 comments
Closed

Testing the persistent store library in github workflows now fails #320

jmichelp opened this issue Jun 9, 2021 · 4 comments
Assignees
@ia0 @jmichelp
Labels
bug Something isn't working
Projects
OpenSK bug triage

Comments

@jmichelp
Copy link
Collaborator

jmichelp commented Jun 9, 2021

Expected Behavior

Tests should pass if the code is left unchanged by a PR

Actual Behavior

Tests fail because the toolchain is not properly set up.

Steps to Reproduce the Problem

  1. Create a PR which doesn't affect the persistent store.

Specifications

  • Version: N/A
  • Platform: N/A
@jmichelp jmichelp added the bug Something isn't working label Jun 9, 2021
@jmichelp jmichelp self-assigned this Jun 9, 2021
@jmichelp jmichelp added this to Needs triage in OpenSK bug triage via automation Jun 9, 2021
@jmichelp jmichelp mentioned this issue Jun 9, 2021
Closed
@ia0 ia0 mentioned this issue Jun 9, 2021
Merged
@kaczmarczyck
Copy link
Collaborator

The fix in #321 mentions it is temporary and needs more work.
@ia0 keep this open?

@kaczmarczyck
Copy link
Collaborator

Ah, I just saw #322, I assume this is what we actually want.

@jmichelp
Copy link
Collaborator Author

@ia0 This has been fixed, right? Or is there anything pending?

@jmichelp jmichelp moved this from Needs triage to High priority in OpenSK bug triage Jun 23, 2021
@ia0
Copy link
Member

ia0 commented Jun 23, 2021

Ah yes sorry, I thought that writing "Fixes #320" in the description of #322 would automatically close this. But apparently I was wrong. Closing manually then.

@ia0 ia0 closed this as completed Jun 23, 2021
OpenSK bug triage automation moved this from High priority to Closed Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ia0 ia0

@jmichelp jmichelp

Labels
bug Something isn't working
Projects
OpenSK bug triage
  
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix persistent store unit testing jmichelp/OpenSK
3 participants
@ia0 @jmichelp @kaczmarczyck